Page MenuHomePhabricator

[OpenMP] Add OMPT support for omp_all_memory task dependence
AcceptedPublic

Authored by protze.joachim on Oct 14 2021, 3:56 AM.

Details

Reviewers
hbae
jdoerfert
Summary

omp_all_memory currently has no representation in OMPT.

Adding new dependency flags as suggested by omp-lang issue #3007.

Diff Detail

Event Timeline

protze.joachim created this revision.Oct 14 2021, 3:56 AM
protze.joachim requested review of this revision.Oct 14 2021, 3:56 AM
hbae accepted this revision.Oct 22 2021, 6:54 AM

LGTM

This revision is now accepted and ready to land.Oct 22 2021, 6:54 AM

We will finish and discuss the spec ticket during the OMPT call next week. I'll commit after the call - just in case we decide for different names.

dreachem added inline comments.
openmp/runtime/src/kmp_taskdeps.cpp
626–627

When would this condition occur in an OpenMP program? Why isn't it enough to just look at whether flags.all is set, as is done below?

protze.joachim added inline comments.Nov 2 2021, 4:05 AM
openmp/runtime/src/kmp_taskdeps.cpp
626–627

D108574 lists two possible compiler interfaces for omp_all_memory. One of them is dependence_address == SIZE_MAX