diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -36,6 +36,7 @@ libc.src.string.strcmp libc.src.string.strcpy libc.src.string.strcspn + libc.src.string.strdup libc.src.string.strlen libc.src.string.strncat libc.src.string.strncmp @@ -237,7 +238,8 @@ libc.src.stdlib.realloc libc.src.stdlib.free - + # string.h entrypoints that depend on malloc + libc.src.string.strdup ) endif() diff --git a/libc/spec/stdc.td b/libc/spec/stdc.td --- a/libc/spec/stdc.td +++ b/libc/spec/stdc.td @@ -279,6 +279,11 @@ RetValSpec, [ArgSpec, ArgSpec] >, + FunctionSpec< + "strdup", + RetValSpec, + [ArgSpec] + >, FunctionSpec< "strpbrk", RetValSpec, diff --git a/libc/src/string/CMakeLists.txt b/libc/src/string/CMakeLists.txt --- a/libc/src/string/CMakeLists.txt +++ b/libc/src/string/CMakeLists.txt @@ -104,6 +104,18 @@ .string_utils ) +add_entrypoint_object( + strdup + SRCS + strdup.cpp + HDRS + strdup.h + DEPENDS + .memcpy + .string_utils + libc.include.stdlib +) + add_entrypoint_object( strlen SRCS diff --git a/libc/src/string/strdup.h b/libc/src/string/strdup.h new file mode 100644 --- /dev/null +++ b/libc/src/string/strdup.h @@ -0,0 +1,20 @@ +//===-- Implementation header for strdup ------------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef LLVM_LIBC_SRC_STRING_STRDUP_H +#define LLVM_LIBC_SRC_STRING_STRDUP_H + +#include + +namespace __llvm_libc { + +char *strdup(const char *src); + +} // namespace __llvm_libc + +#endif // LLVM_LIBC_SRC_STRING_STRDUP_H diff --git a/libc/src/string/strdup.cpp b/libc/src/string/strdup.cpp new file mode 100644 --- /dev/null +++ b/libc/src/string/strdup.cpp @@ -0,0 +1,32 @@ +//===-- Implementation of strdup ------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "src/string/strdup.h" +#include "src/string/memcpy.h" +#include "src/string/string_utils.h" + +#include "src/__support/common.h" + +#include + +namespace __llvm_libc { + +LLVM_LIBC_FUNCTION(char *, strdup, (const char *src)) { + if (src == nullptr) { + return nullptr; + } + size_t len = internal::string_length(src) + 1; + char *dest = reinterpret_cast(::malloc(len)); // NOLINT + if (dest == nullptr) { + return nullptr; + } + char *result = reinterpret_cast(__llvm_libc::memcpy(dest, src, len)); + return result; +} + +} // namespace __llvm_libc diff --git a/libc/test/src/string/CMakeLists.txt b/libc/test/src/string/CMakeLists.txt --- a/libc/test/src/string/CMakeLists.txt +++ b/libc/test/src/string/CMakeLists.txt @@ -92,6 +92,17 @@ libc.src.string.strcspn ) +add_libc_unittest( + strdup_test + SUITE + libc_string_unittests + SRCS + strdup_test.cpp + DEPENDS + libc.include.stdlib + libc.src.string.strdup +) + add_libc_unittest( strlen_test SUITE diff --git a/libc/test/src/string/strdup_test.cpp b/libc/test/src/string/strdup_test.cpp new file mode 100644 --- /dev/null +++ b/libc/test/src/string/strdup_test.cpp @@ -0,0 +1,39 @@ +//===-- Unittests for strdup ----------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "src/string/strdup.h" +#include "utils/UnitTest/Test.h" +#include + +TEST(LlvmLibcStrDupTest, EmptyString) { + const char *empty = ""; + + char *result = __llvm_libc::strdup(empty); + ASSERT_NE(result, static_cast(nullptr)); + ASSERT_NE(empty, const_cast(result)); + ASSERT_STREQ(empty, result); + ::free(result); +} + +TEST(LlvmLibcStrDupTest, AnyString) { + const char *abc = "abc"; + + char *result = __llvm_libc::strdup(abc); + + ASSERT_NE(result, static_cast(nullptr)); + ASSERT_NE(abc, const_cast(result)); + ASSERT_STREQ(abc, result); + ::free(result); +} + +TEST(LlvmLibcStrDupTest, NullPtr) { + + char *result = __llvm_libc::strdup(nullptr); + + ASSERT_EQ(result, static_cast(nullptr)); +}