Page MenuHomePhabricator

[OpenMP][FIX] Data race in the SPMD execution of the new runtime
ClosedPublic

Authored by jdoerfert on Oct 7 2021, 5:10 PM.

Details

Summary

We need to synchronize the threads *before* we destroy the RAII objects
that hold the old values and not after to avoid threads executing the
parallel region but seeing an inconsistent state.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 7 2021, 5:10 PM
jdoerfert requested review of this revision.Oct 7 2021, 5:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2021, 5:10 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
tianshilei1992 accepted this revision.Oct 7 2021, 5:14 PM

Yeah, that's the one. LGTM

This revision is now accepted and ready to land.Oct 7 2021, 5:14 PM
This revision was landed with ongoing or failed builds.Oct 7 2021, 6:01 PM
This revision was automatically updated to reflect the committed changes.