diff --git a/flang/include/flang/Optimizer/Support/FIRContext.h b/flang/include/flang/Optimizer/Support/FIRContext.h --- a/flang/include/flang/Optimizer/Support/FIRContext.h +++ b/flang/include/flang/Optimizer/Support/FIRContext.h @@ -22,7 +22,7 @@ namespace mlir { class ModuleOp; -} +} // namespace mlir namespace fir { class KindMapping; diff --git a/flang/include/flang/Optimizer/Support/InternalNames.h b/flang/include/flang/Optimizer/Support/InternalNames.h --- a/flang/include/flang/Optimizer/Support/InternalNames.h +++ b/flang/include/flang/Optimizer/Support/InternalNames.h @@ -54,10 +54,10 @@ : modules{modules.begin(), modules.end()}, host{host}, name{name}, kinds{kinds.begin(), kinds.end()} {} - llvm::SmallVector modules; + llvm::SmallVector modules; llvm::Optional host; std::string name; - llvm::SmallVector kinds; + llvm::SmallVector kinds; }; /// Unique a common block name diff --git a/flang/lib/Optimizer/Support/FIRContext.cpp b/flang/lib/Optimizer/Support/FIRContext.cpp --- a/flang/lib/Optimizer/Support/FIRContext.cpp +++ b/flang/lib/Optimizer/Support/FIRContext.cpp @@ -33,14 +33,14 @@ static constexpr const char *defKindName = "fir.defaultkind"; void fir::setKindMapping(mlir::ModuleOp mod, fir::KindMapping &kindMap) { - auto ctx = mod.getContext(); + auto *ctx = mod.getContext(); mod->setAttr(kindMapName, mlir::StringAttr::get(ctx, kindMap.mapToString())); auto defs = kindMap.defaultsToString(); mod->setAttr(defKindName, mlir::StringAttr::get(ctx, defs)); } fir::KindMapping fir::getKindMapping(mlir::ModuleOp mod) { - auto ctx = mod.getContext(); + auto *ctx = mod.getContext(); if (auto defs = mod->getAttrOfType(defKindName)) { auto defVals = fir::KindMapping::toDefaultKinds(defs.getValue()); if (auto maps = mod->getAttrOfType(kindMapName)) diff --git a/flang/lib/Optimizer/Support/InternalNames.cpp b/flang/lib/Optimizer/Support/InternalNames.cpp --- a/flang/lib/Optimizer/Support/InternalNames.cpp +++ b/flang/lib/Optimizer/Support/InternalNames.cpp @@ -21,7 +21,7 @@ llvm::cl::desc("override the name of the default PROGRAM entry (may be " "helpful for using other runtimes)")); -constexpr std::int64_t BAD_VALUE = -1; +constexpr std::int64_t badValue = -1; inline std::string prefix() { return "_Q"; } @@ -69,9 +69,9 @@ for (i = init; i < end && uniq[i] >= '0' && uniq[i] <= '9'; ++i) { // do nothing } - std::int64_t result = BAD_VALUE; + std::int64_t result = badValue; if (uniq.substr(init, i - init).getAsInteger(10, result)) - return BAD_VALUE; + return badValue; return result; } @@ -223,10 +223,10 @@ std::pair fir::NameUniquer::deconstruct(llvm::StringRef uniq) { if (uniq.startswith("_Q")) { - llvm::SmallVector modules; + llvm::SmallVector modules; llvm::Optional host; std::string name; - llvm::SmallVector kinds; + llvm::SmallVector kinds; NameKind nk = NameKind::NOT_UNIQUED; for (std::size_t i = 2, end{uniq.size()}; i != end;) { switch (uniq[i]) { diff --git a/flang/lib/Optimizer/Support/KindMapping.cpp b/flang/lib/Optimizer/Support/KindMapping.cpp --- a/flang/lib/Optimizer/Support/KindMapping.cpp +++ b/flang/lib/Optimizer/Support/KindMapping.cpp @@ -49,8 +49,8 @@ /// Integral types default to the kind value being the size of the value in /// bytes. The default is to scale from bytes to bits. static Bitsize defaultScalingKind(KindTy kind) { - const unsigned BITS_IN_BYTE = 8; - return kind * BITS_IN_BYTE; + const unsigned bitsInByte = 8; + return kind * bitsInByte; } /// Floating-point types default to the kind value being the size of the value