diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp --- a/llvm/lib/Transforms/Utils/Local.cpp +++ b/llvm/lib/Transforms/Utils/Local.cpp @@ -1908,12 +1908,19 @@ } Type *Type = CI->getType(); + if (Type->isPointerTy()) + Type = DL.getIntPtrType(Type); // Casts other than Trunc, SExt, or ZExt to scalar types cannot be salvaged. if (Type->isVectorTy() || - !(isa(&I) || isa(&I) || isa(&I))) + !(isa(&I) || isa(&I) || isa(&I) || + isa(&I) || isa(&I))) return nullptr; - unsigned FromTypeBitSize = FromValue->getType()->getScalarSizeInBits(); + llvm::Type *FromType = FromValue->getType(); + if (FromType->isPointerTy()) + FromType = DL.getIntPtrType(FromType); + + unsigned FromTypeBitSize = FromType->getScalarSizeInBits(); unsigned ToTypeBitSize = Type->getScalarSizeInBits(); auto ExtOps = DIExpression::getExtOps(FromTypeBitSize, ToTypeBitSize, @@ -1924,9 +1931,9 @@ if (auto *GEP = dyn_cast(&I)) return getSalvageOpsForGEP(GEP, DL, CurrentLocOps, Ops, AdditionalValues); - else if (auto *BI = dyn_cast(&I)) { + if (auto *BI = dyn_cast(&I)) return getSalvageOpsForBinOp(BI, CurrentLocOps, Ops, AdditionalValues); - } + // *Not* to do: we should not attempt to salvage load instructions, // because the validity and lifetime of a dbg.value containing // DW_OP_deref becomes difficult to analyze. See PR40628 for examples. diff --git a/llvm/test/Transforms/Util/salvage-debuginfo.ll b/llvm/test/Transforms/Util/salvage-debuginfo.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Transforms/Util/salvage-debuginfo.ll @@ -0,0 +1,27 @@ +; RUN: opt -adce %s -S -o - | FileCheck %s +target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-apple-macosx" +define void @f(i32) !dbg !8 { +entry: + %p_x = inttoptr i32 %0 to i8* + %i_x = ptrtoint i8* %p_x to i32 + ; CHECK: call void @llvm.dbg.value(metadata i8* undef, + ; CHECK-SAME: !DIExpression(DW_OP_LLVM_convert, 64, DW_ATE_unsigned, + ; CHECK-SAME: DW_OP_LLVM_convert, 32, DW_ATE_unsigned, DW_OP_stack_value)) + call void @llvm.dbg.value(metadata i32 %i_x, metadata !11, metadata !DIExpression()), !dbg !13 + ret void, !dbg !13 +} +declare void @llvm.dbg.value(metadata, metadata, metadata) + +!llvm.dbg.cu = !{!0} +!llvm.module.flags = !{!3, !4} +!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, emissionKind: FullDebug) +!1 = !DIFile(filename: "salavage.c", directory: "/") +!3 = !{i32 2, !"Dwarf Version", i32 4} +!4 = !{i32 2, !"Debug Info Version", i32 3} +!8 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 1, type: !9, isLocal: false, isDefinition: true, scopeLine: 1, isOptimized: false, unit: !0) +!9 = !DISubroutineType(types: !10) +!10 = !{null} +!11 = !DILocalVariable(name: "x", scope: !8, file: !1, line: 2, type: !12) +!12 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed) +!13 = !DILocation(line: 1, column: 1, scope: !8)