Page MenuHomePhabricator

[AMDGPU][Libomptarget] Simplify host memory pool lookup
Needs ReviewPublic

Authored by pdhaliwal on Sep 15 2021, 7:39 PM.

Details

Summary

Using lambda for host memory pool was causing stack smashing
error on CI. Using plain for loop fixed the issue.

Diff Detail

Event Timeline

pdhaliwal created this revision.Sep 15 2021, 7:39 PM
pdhaliwal requested review of this revision.Sep 15 2021, 7:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2021, 7:39 PM

Is it possible to split this into a refactor and a behaviour change patch? Hard to tell what the semantic change is here

pdhaliwal updated this revision to Diff 372894.Sep 16 2021, 4:05 AM

Split this patch into two,

  1. Current patch now only includes changes for simplifying the host pool lookup
  2. D109875 includes plain refactoring.
pdhaliwal retitled this revision from [AMDGPU][Libomptarget] Simplify setup of host/device memory pools to [AMDGPU][Libomptarget] Simplify host memory pool lookup.Sep 16 2021, 4:07 AM
pdhaliwal edited the summary of this revision. (Show Details)

I think this patch includes the refactor so I'm going to hold off on trying to review it until it can be rebased on main after the refactor lands. It's also possible to make a diff relative to another one though I'm not sure on the proper workflow for doing so.

pdhaliwal added a comment.EditedSep 19 2021, 8:55 PM

This is not dependent on D109875, instead it is the other case. Apologies for not mentioning here. Diff shown here is messed up.