[OpenMP] Declare variants for templates need to match # template args
ClosedPublic
Actions

Authored by jdoerfert on Sep 14 2021, 9:30 AM.

Details

Reviewers

pdhaliwal
JonChesterfield

Commits

rG6cf6fa6ef1c2: [OpenMP] Declare variants for templates need to match # template args

Summary

A declare variant template is only compatible with a base when the
number of template arguments is equal, otherwise our instantiations will
produce nonsensical results.

Exposes as part of D109344.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jdoerfert created this revision.Sep 14 2021, 9:30 AM

Herald added subscribers: guansong, bollu, yaxunl. · View Herald TranscriptSep 14 2021, 9:30 AM

jdoerfert requested review of this revision.Sep 14 2021, 9:30 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2021, 9:30 AM

Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript

Ah, nice! Thanks for the fix

This revision is now accepted and ready to land.Sep 14 2021, 9:32 AM

Harbormaster completed remote builds in B123858: Diff 372503.Sep 14 2021, 10:35 AM

This revision was landed with ongoing or failed builds.Oct 27 2021, 7:05 PM

Closed by commit rG6cf6fa6ef1c2: [OpenMP] Declare variants for templates need to match # template args (authored by jdoerfert). · Explain Why

This revision was automatically updated to reflect the committed changes.

jdoerfert added a commit: rG6cf6fa6ef1c2: [OpenMP] Declare variants for templates need to match # template args.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

Path

Size

clang/

lib/

Sema/

SemaOpenMP.cpp

8 lines

test/

AST/

ast-dump-openmp-begin-declare-variant_template_4.cpp

99 lines

Diff 382883

View Options

clang/lib/Sema/SemaOpenMP.cpp