Add capability to get and set the personalitty function from the C API

[deadalnix]

Summary

The capability was lost with D10429 where the personality function was set at function level rather than landing pad level. Now there is no way to get/set the personality function from the C API. That is a problem.

Note that the whole thing could be avoided by improving the C API testing, as started by D10725

[rnk]

What is the effect of setting the personality of a landingpad personality now? We should probably make it update the personality of the parent function, so that simple frontends keep working.

Adding this also seems reasonable.

[• rafael]

Should we just delete the old functions? We should at the very least
deprecate them and schedule them for removal.

[deadalnix]

The old function has been deleted? Setting the landing pad is just not possible anymore via the C API.

[deadalnix]

The old function has been deleted. Setting the landing pad is just not possible anymore via the C API.

[• rafael]

Lgtm

[deadalnix]

Ping ? Can we get that in so that we can at least get the same functionality as before from the C API ?

[axw]

In D10946#203416, @deadalnix wrote:

Ping ? Can we get that in so that we can at least get the same functionality as before from the C API ?

Done, thanks for fixing this.

include/llvm-c/Core.h

 /**
  * Remove a function from its containing module and deletes it.
  *
  * @see llvm::Function::eraseFromParent()
  */
 void LLVMDeleteFunction(LLVMValueRef Fn);
 
 /**
+ * Obtain the personality function attached to the function.
+ *
+ * @see llvm::Function::getPersonalityFn()
+ */
+LLVMValueRef LLVMGetPersonalityFn(LLVMValueRef Fn);
+
+/**
+ * Set the personality function attached to the function.
+ *
+ * @see llvm::Function::setPersonalityFn()
+ */
+void LLVMSetPersonalityFn(LLVMValueRef Fn, LLVMValueRef PersonalityFn);
+
+/**
  * Obtain the ID number from a function instance.
  *
  * @see llvm::Function::getIntrinsicID()
  */
 unsigned LLVMGetIntrinsicID(LLVMValueRef Fn);
 
 /**
  * Obtain the calling function of a function.

lib/IR/Core.cpp

if (I == Func->getParent()->begin())
     return nullptr;
   return wrap(--I);
 }
 
 void LLVMDeleteFunction(LLVMValueRef Fn) {
   unwrap<Function>(Fn)->eraseFromParent();
 }
 
+LLVMValueRef LLVMGetPersonalityFn(LLVMValueRef Fn) {
+  return wrap(unwrap<Function>(Fn)->getPersonalityFn());
+}
+
+void LLVMSetPersonalityFn(LLVMValueRef Fn, LLVMValueRef PersonalityFn) {
+  unwrap<Function>(Fn)->setPersonalityFn(unwrap<Constant>(PersonalityFn));
+}
+
 unsigned LLVMGetIntrinsicID(LLVMValueRef Fn) {
   if (Function *F = dyn_cast<Function>(unwrap(Fn)))
     return F->getIntrinsicID();
   return 0;
 }
 
 unsigned LLVMGetFunctionCallConv(LLVMValueRef Fn) {
   return unwrap<Function>(Fn)->getCallingConv();