Page MenuHomePhabricator
Differential D109259

[SROA] Support opaque pointers
ClosedPublic
Actions

Authored by nikic on Sep 3 2021, 2:17 PM.

Details

Reviewers
aeubanks
Group Reviewers
Restricted Project
Commits
rG6dfdc6bfd22a: [SROA] Support opaque pointers
Summary

Make the following changes in order to support opaque pointers in SROA:

  • Generate i8 GEPs for opaque pointers.
  • Explicitly enforce that promotable allocas only have stores of the alloca type -- previously this was implicitly enforced.
  • Replace a check for pointer element type with load/store type.

Diff Detail

Event Timeline

nikic created this revision.Sep 3 2021, 2:17 PM
Herald added subscribers: dexonsmith, hiraditya. · View Herald TranscriptSep 3 2021, 2:17 PM
nikic requested review of this revision.Sep 3 2021, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 2:17 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B122583: Diff 370671.Sep 3 2021, 3:02 PM
aeubanks added a subscriber: aeubanks.Sep 3 2021, 4:46 PM

I think we should revisit the i8 GEP discussion again in llvm-dev, last time in https://groups.google.com/g/llvm-dev/c/NkslevE-MGM/m/jY1CkHxfBAAJ I think there wasn't enough consensus around this.

nikic mentioned this in D109290: [OpaquePtr] Forbid mixing typed and opaque pointers.Sep 5 2021, 8:02 AM
• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM
• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM
thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM
thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM
aeubanks accepted this revision.Sep 7 2021, 2:08 PM
aeubanks added inline comments.
llvm/test/Transforms/SROA/basictest-opaque-ptrs.ll
123

in the original test this is a i64 addrspace(1)* but here we've dropped the addrspace(1)
are we missing an addrspacecast? the original code path had a cast if the final pointer type didn't match the desired pointer type

This revision is now accepted and ready to land.Sep 7 2021, 2:08 PM
aeubanks requested changes to this revision.Sep 7 2021, 2:09 PM
This revision now requires changes to proceed.Sep 7 2021, 2:09 PM
nikic updated this revision to Diff 371411.Sep 8 2021, 12:00 PM

Add missing addrspacecast, add name for GEP.

nikic marked an inline comment as done.Sep 8 2021, 12:02 PM
nikic added inline comments.
llvm/test/Transforms/SROA/basictest-opaque-ptrs.ll
123

Nice catch! I've added the missing pointer cast.

Harbormaster completed remote builds in B123096: Diff 371411.Sep 8 2021, 1:09 PM
aeubanks accepted this revision.Sep 8 2021, 1:09 PM
This revision is now accepted and ready to land.Sep 8 2021, 1:09 PM
Closed by commit rG6dfdc6bfd22a: [SROA] Support opaque pointers (authored by nikic). · Explain WhySep 8 2021, 1:26 PM
This revision was automatically updated to reflect the committed changes.
nikic marked an inline comment as done.
nikic added a commit: rG6dfdc6bfd22a: [SROA] Support opaque pointers.
nikic mentioned this in rG90ec6dff860f: [OpaquePtr] Forbid mixing typed and opaque pointers.Sep 10 2021, 6:20 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Scalar/
22 lines
Utils/
3 lines
test/
Transforms/
SROA/
2157 lines

Diff 371431

View Options

llvm/lib/Transforms/Scalar/SROA.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

Loading...
View Options

llvm/test/Transforms/SROA/basictest-opaque-ptrs.ll

Loading...