diff --git a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp --- a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -1087,7 +1087,7 @@ SemaRef.BuildVariableInstantiation(Var, D, TemplateArgs, LateAttrs, Owner, StartingScope, InstantiatingVarTemplate); - if (D->isNRVOVariable()) { + if (D->isNRVOVariable() && !Var->isInvalidDecl()) { QualType RT; if (auto *F = dyn_cast(DC)) RT = F->getReturnType(); diff --git a/clang/test/CXX/class/class.init/class.copy.elision/p3.cpp b/clang/test/CXX/class/class.init/class.copy.elision/p3.cpp --- a/clang/test/CXX/class/class.init/class.copy.elision/p3.cpp +++ b/clang/test/CXX/class/class.init/class.copy.elision/p3.cpp @@ -518,3 +518,37 @@ template X test_dependent_invalid_decl(); // expected-note {{requested here}} } // namespace test_auto_variables + +namespace PR51708 { + +class a1; // expected-note 4 {{forward declaration of 'PR51708::a1'}} +template class A2; // expected-note 4 {{template is declared here}} +using a2 = A2; + +template b f() { + // expected-error@-1 {{incomplete result type 'PR51708::a1' in function definition}} + // expected-error@-2 {{implicit instantiation of undefined template 'PR51708::A2}} + + b d; + // expected-error@-1 {{variable has incomplete type 'PR51708::a1'}} + // expected-error@-2 {{implicit instantiation of undefined template 'PR51708::A2}} + + return d; +} +template a1 f(); // expected-note-re {{in instantiation {{.*}} requested here}} +template a2 f(); // expected-note-re {{in instantiation {{.*}} requested here}} + +template b g() { + // expected-error@-1 {{incomplete result type 'PR51708::a1' in function definition}} + // expected-error@-2 {{implicit instantiation of undefined template 'PR51708::A2}} + + b d __attribute__((aligned(1))); + // expected-error@-1 {{variable has incomplete type 'PR51708::a1'}} + // expected-error@-2 {{implicit instantiation of undefined template 'PR51708::A2}} + + return d; +} +template a1 g(); // expected-note-re {{in instantiation {{.*}} requested here}} +template a2 g(); // expected-note-re {{in instantiation {{.*}} requested here}} + +} // namespace PR51708