diff --git a/lld/MachO/InputFiles.cpp b/lld/MachO/InputFiles.cpp --- a/lld/MachO/InputFiles.cpp +++ b/lld/MachO/InputFiles.cpp @@ -282,16 +282,21 @@ } else { auto *isec = make(segname, name, this, data, align, flags); - if (!(isDebugSection(isec->getFlags()) && - isec->getSegName() == segment_names::dwarf)) { - subsections.push_back({{0, isec}}); - } else { + if (isDebugSection(isec->getFlags()) && + isec->getSegName() == segment_names::dwarf) { // Instead of emitting DWARF sections, we emit STABS symbols to the // object files that contain them. We filter them out early to avoid // parsing their relocations unnecessarily. But we must still push an // empty map to ensure the indices line up for the remaining sections. subsections.push_back({}); debugSections.push_back(isec); + } else if (isec->getSegName() == segment_names::llvm) { + // Sections within the llvm segment aren't known to produce induce + // symbols errors. Push an empty map to ensure indices line up for the + // remaining sections. + subsections.push_back({}); + } else { + subsections.push_back({{0, isec}}); } } } diff --git a/lld/test/MachO/ignore-symbols.s b/lld/test/MachO/ignore-symbols.s new file mode 100644 --- /dev/null +++ b/lld/test/MachO/ignore-symbols.s @@ -0,0 +1,19 @@ +# REQUIRES: x86 +# RUN: rm -rf %t; split-file %s %t +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/foo.s -o %t/foo.o +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/bar.s -o %t/bar.o +## _llvm. symbols are not special. LLD would produce duplicate symbol errors +## if they were not within the LLVM segment. +# RUN: %lld -dylib %t/foo.o %t/bar.o -o %t/libDuplicate.dylib + +#--- foo.s +.globl _llvm.foo +.section __LLVM,__bitcode +_llvm.foo: +.asciz "test" + +#--- bar.s +.globl _llvm.foo +.section __LLVM,__bitcode +_llvm.foo: +.asciz "test"