diff --git a/compiler-rt/lib/tsan/rtl/tsan_debugging.cpp b/compiler-rt/lib/tsan/rtl/tsan_debugging.cpp --- a/compiler-rt/lib/tsan/rtl/tsan_debugging.cpp +++ b/compiler-rt/lib/tsan/rtl/tsan_debugging.cpp @@ -195,7 +195,7 @@ const char *region_kind = nullptr; if (name && name_size > 0) name[0] = 0; - if (IsMetaMem(addr)) { + if (IsMetaMem(reinterpret_cast(addr))) { region_kind = "meta shadow"; } else if (IsShadowMem(addr)) { region_kind = "shadow"; diff --git a/compiler-rt/lib/tsan/rtl/tsan_platform.h b/compiler-rt/lib/tsan/rtl/tsan_platform.h --- a/compiler-rt/lib/tsan/rtl/tsan_platform.h +++ b/compiler-rt/lib/tsan/rtl/tsan_platform.h @@ -892,7 +892,8 @@ } ALWAYS_INLINE -bool IsMetaMem(uptr mem) { +bool IsMetaMem(const u32 *p) { + uptr mem = reinterpret_cast(p); #if defined(__aarch64__) && !defined(__APPLE__) && !SANITIZER_GO switch (vmaSize) { case 39: return IsMetaMemImpl(mem); @@ -926,7 +927,6 @@ #endif } - template uptr MemToShadowImpl(uptr x) { DCHECK(IsAppMem(x)); diff --git a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp --- a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp +++ b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp @@ -328,7 +328,7 @@ if (p < beg || p >= end) continue; const uptr s = MemToShadow(p); - const uptr m = (uptr)MemToMeta(p); + u32 *const m = MemToMeta(p); VPrintf(3, " checking pointer %p: shadow=%p meta=%p\n", p, s, m); CHECK(IsAppMem(p)); CHECK(IsShadowMem(s)); @@ -338,10 +338,9 @@ // Ensure that shadow and meta mappings are linear within a single // user range. Lots of code that processes memory ranges assumes it. const uptr prev_s = MemToShadow(prev); - const uptr prev_m = (uptr)MemToMeta(prev); + u32 *const prev_m = MemToMeta(prev); CHECK_EQ(s - prev_s, (p - prev) * kShadowMultiplier); - CHECK_EQ((m - prev_m) / kMetaShadowSize, - (p - prev) / kMetaShadowCell); + CHECK_EQ(m - prev_m, (p - prev) / kMetaShadowCell); } prev = p; }