diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -8763,6 +8763,8 @@ " in asm %select{input|output}1 with a memory constraint '%2'">; def err_asm_input_duplicate_match : Error< "more than one input constraint matches the same output '%0'">; + def err_store_value_to_reg : Error< + "impossible constraint in asm: can't store value into a register">; def warn_asm_label_on_auto_decl : Warning< "ignored asm label '%0' on automatic variable">; diff --git a/clang/lib/CodeGen/CGStmt.cpp b/clang/lib/CodeGen/CGStmt.cpp --- a/clang/lib/CodeGen/CGStmt.cpp +++ b/clang/lib/CodeGen/CGStmt.cpp @@ -2725,9 +2725,8 @@ QualType Ty = getContext().getIntTypeForBitwidth(Size, /*Signed*/ false); if (Ty.isNull()) { const Expr *OutExpr = S.getOutputExpr(i); - CGM.Error( - OutExpr->getExprLoc(), - "impossible constraint in asm: can't store value into a register"); + CGM.getDiags().Report(OutExpr->getExprLoc(), + diag::err_store_value_to_reg); return; } Dest = MakeAddrLValue(A, Ty); diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp --- a/clang/lib/Sema/SemaStmtAsm.cpp +++ b/clang/lib/Sema/SemaStmtAsm.cpp @@ -667,8 +667,17 @@ // output was a register, just extend the shorter one to the size of the // larger one. if (!SmallerValueMentioned && InputDomain != AD_Other && - OutputConstraintInfos[TiedTo].allowsRegister()) + OutputConstraintInfos[TiedTo].allowsRegister()) { + // FIXME: GCC supports the OutSize to be 128 at maximum. Currently codegen + // crash when the size larger than the register size. So we limit it here. + if (OutTy->isStructureType() && + Context.getIntTypeForBitwidth(OutSize, /*Signed*/ false).isNull()) { + targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg); + return NS; + } + continue; + } // Either both of the operands were mentioned or the smaller one was // mentioned. One more special case that we'll allow: if the tied input is diff --git a/clang/test/Sema/asm.c b/clang/test/Sema/asm.c --- a/clang/test/Sema/asm.c +++ b/clang/test/Sema/asm.c @@ -313,3 +313,54 @@ asm ("jne %l0":::); asm goto ("jne %l0"::::lab); } + +typedef struct _st_size64 { + int a; + char b; +} st_size64; + +typedef struct _st_size96 { + int a; + int b; + int c; +} st_size96; + +typedef struct _st_size16 { + char a; + char b; +} st_size16; + +typedef struct _st_size32 { + char a; + char b; + char c; + char d; +} st_size32; + +typedef struct _st_size128 { + int a; + int b; + int c; + int d; +} st_size128; + +void test19(long long x) +{ + st_size64 a; + st_size96 b; + st_size16 c; + st_size32 d; + st_size128 e; + asm ("" : "=rm" (a): "0" (1)); // no-error + asm ("" : "=rm" (d): "0" (1)); // no-error + asm ("" : "=rm" (c): "0" (x)); // no-error + // FIXME: This case is actually supported by codegen. + asm ("" : "=rm" (x): "0" (a)); // expected-error {{unsupported inline asm: input with type 'st_size64' (aka 'struct _st_size64') matching output with type 'long long'}} + // FIXME: This case is actually supported by codegen. + asm ("" : "=rm" (a): "0" (d)); // expected-error {{unsupported inline asm: input with type 'st_size32' (aka 'struct _st_size32') matching output with type 'st_size64' (aka 'struct _st_size64')}} + asm ("" : "=rm" (b): "0" (1)); // expected-error {{impossible constraint in asm: can't store value into a register}} + // FIXME: This case should be supported by codegen, but it fails now. + asm ("" : "=rm" (e): "0" (1)); // no-error + // FIXME: This case should be supported by codegen, but it fails now. + asm ("" : "=rm" (x): "0" (e)); // expected-error {{unsupported inline asm: input with type 'st_size128' (aka 'struct _st_size128') matching output with type 'long long'}} +}