Page MenuHomePhabricator

PR23872 Integrated assembler error message when using .type directive with @ in AArch32 assembly
ClosedPublic

Authored by enefaim on Jun 23 2015, 6:40 AM.

Details

Summary

In AArch32 assembler the @ is a comment symbol, so the error message shouldn't suggest
that '@<type>' is a valid replacement when assembling AArch32.

Diff Detail

Repository
rL LLVM

Event Timeline

enefaim updated this revision to Diff 28234.Jun 23 2015, 6:40 AM
enefaim retitled this revision from to PR23872 Integrated assembler error message when using .type directive with @ in AArch32 assembly.
enefaim updated this object.
enefaim edited the test plan for this revision. (Show Details)
enefaim set the repository for this revision to rL LLVM.
enefaim added a subscriber: Unknown Object (MLST).

Hi Gabor

This patch LGTM - I think we should commit it.

Thanks
Rich

Are there any other targets that we should test it on?

Hi Richard,

Are there any other targets that we should test it on?

I don't know about any other target that uses the @ sign as comment
symbol besides ARM.

Thanks,
Gabor

Wont the definition getAllowAtInIdentifier tell you?

enefaim updated this revision to Diff 28559.Jun 26 2015, 7:57 AM
enefaim edited edge metadata.

New in this version:

  • Added more test targets that use @ as comment symbol.
This revision was automatically updated to reflect the committed changes.