Page MenuHomePhabricator

ARMLoadStoreOptimizer: Fix errata 602117 handling and make testcase actually test for it
ClosedPublic

Authored by MatzeB on Jun 22 2015, 4:25 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 28169.Jun 22 2015, 4:25 PM
MatzeB retitled this revision from to ARMLoadStoreOptimizer: Fix errata 602117 handling and make testcase actually test for it.
MatzeB updated this object.
MatzeB edited the test plan for this revision. (Show Details)
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: Unknown Object (MLST).

Looks good, but a few minor comments.

lib/Target/ARM/ARMLoadStoreOptimizer.cpp
1468 ↗(On Diff #28169)

Only LDRD is affected by the cortex-m3 erratum, so t2STRDi8 is not needed here.

1480 ↗(On Diff #28169)

ShouldBreakApart isn't really the right name, as the LDRD could be converted to LDM and not broken apart.

test/CodeGen/ARM/ldrd.ll
11 ↗(On Diff #28169)

Capitalise the We.

This revision was automatically updated to reflect the committed changes.