diff --git a/clang/lib/Headers/opencl-c-base.h b/clang/lib/Headers/opencl-c-base.h --- a/clang/lib/Headers/opencl-c-base.h +++ b/clang/lib/Headers/opencl-c-base.h @@ -164,7 +164,9 @@ typedef double double16 __attribute__((ext_vector_type(16))); #endif -#if defined(__OPENCL_CPP_VERSION__) || defined(__OPENCL_C_VERSION__) +#if defined(__OPENCL_CPP_VERSION__) +#define NULL nullptr +#elif defined(__OPENCL_C_VERSION__) #define NULL ((void*)0) #endif diff --git a/clang/test/SemaOpenCL/null_literal.cl b/clang/test/SemaOpenCL/null_literal.cl --- a/clang/test/SemaOpenCL/null_literal.cl +++ b/clang/test/SemaOpenCL/null_literal.cl @@ -1,31 +1,48 @@ -// RUN: %clang_cc1 -verify %s -// RUN: %clang_cc1 -cl-std=CL1.0 -verify %s -// RUN: %clang_cc1 -cl-std=CL1.1 -verify %s -// RUN: %clang_cc1 -cl-std=CL1.2 -verify %s -// RUN: %clang_cc1 -cl-std=CL2.0 -DCL20 -verify %s - -#define NULL ((void*)0) +// RUN: %clang_cc1 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.0 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.1 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.2 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL2.0 -DCL20 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=clc++ -fdeclare-opencl-builtins -finclude-default-header -verify %s void foo(){ global int* ptr1 = NULL; +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+2{{cannot initialize a variable of type '__global int *__private' with an rvalue of type '__global void *'}} +#endif global int* ptr2 = (global void*)0; constant int* ptr3 = NULL; -constant int* ptr4 = (global void*)0; // expected-error{{initializing '__constant int *__private' with an expression of type '__global void *' changes address space of pointer}} +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+4{{cannot initialize a variable of type '__constant int *__private' with an rvalue of type '__global void *'}} +#else +// expected-error@+2{{initializing '__constant int *__private' with an expression of type '__global void *' changes address space of pointer}} +#endif +constant int* ptr4 = (global void*)0; #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. global int* ptr5 = (generic void*)0; #endif -global int* ptr6 = (local void*)0; // expected-error{{initializing '__global int *__private' with an expression of type '__local void *' changes address space of pointer}} +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+4{{cannot initialize a variable of type '__global int *__private' with an rvalue of type '__local void *'}} +#else +// expected-error@+2{{initializing '__global int *__private' with an expression of type '__local void *' changes address space of pointer}} +#endif +global int* ptr6 = (local void*)0; bool cmp = ptr1 == NULL; -cmp = ptr1 == (local void*)0; // expected-error{{comparison between ('__global int *' and '__local void *') which are pointers to non-overlapping address spaces}} +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+4{{comparison of distinct pointer types ('__global int *' and '__local void *')}} +#else +// expected-error@+2{{comparison between ('__global int *' and '__local void *') which are pointers to non-overlapping address spaces}} +#endif +cmp = ptr1 == (local void*)0; cmp = ptr3 == NULL;