diff --git a/llvm/lib/CodeGen/MachineVerifier.cpp b/llvm/lib/CodeGen/MachineVerifier.cpp --- a/llvm/lib/CodeGen/MachineVerifier.cpp +++ b/llvm/lib/CodeGen/MachineVerifier.cpp @@ -1782,6 +1782,16 @@ // TODO: verify we have properly encoded deopt arguments } break; + case TargetOpcode::INSERT_SUBREG: { + const auto &TRI = MRI->getTargetRegisterInfo(); + unsigned InsertedSize = + TRI->getRegSizeInBits(MI->getOperand(2).getReg(), *MRI); + unsigned SubRegSize = TRI->getSubRegIdxSize(MI->getOperand(3).getImm()); + if (InsertedSize != SubRegSize) { + report("INSERT_SUBREG expected matching subreg size for operand 2", MI); + break; + } + } break; } } diff --git a/llvm/test/MachineVerifier/test_insert_subreg.mir b/llvm/test/MachineVerifier/test_insert_subreg.mir new file mode 100644 --- /dev/null +++ b/llvm/test/MachineVerifier/test_insert_subreg.mir @@ -0,0 +1,29 @@ +#RUN: not --crash llc -march=aarch64 -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s +# REQUIRES: aarch64-registered-target + +--- +name: test_insert_subreg +legalized: true +regBankSelected: false +selected: false +tracksRegLiveness: true +liveins: +body: | + bb.0: + liveins: $s0, $h1 + + %0:fpr32 = COPY $s0 + + ; CHECK: *** Bad machine code: INSERT_SUBREG expected matching subreg size for operand 2 *** + %1:fpr128 = IMPLICIT_DEF + %2:fpr128 = INSERT_SUBREG %1:fpr128, %0:fpr32, %subreg.hsub + + ; CHECK: *** Bad machine code: INSERT_SUBREG expected matching subreg size for operand 2 *** + %3:fpr128 = IMPLICIT_DEF + %4:fpr128 = INSERT_SUBREG %3:fpr128, %0:fpr32, %subreg.dsub + + ; CHECK-NOT: *** Bad machine code: + %7:fpr128 = IMPLICIT_DEF + %8:fpr128 = INSERT_SUBREG %7:fpr128, %0:fpr32, %subreg.ssub + +...