Index: mlir/include/mlir/Dialect/EmitC/IR/EmitC.td =================================================================== --- mlir/include/mlir/Dialect/EmitC/IR/EmitC.td +++ mlir/include/mlir/Dialect/EmitC/IR/EmitC.td @@ -126,12 +126,15 @@ ```mlir // Custom form defining the inclusion of ``. - emitc.include "myheader.h" is_standard_include + emitc.include <"myheader.h"> // Generic form of the same operation. "emitc.include" (){include = "myheader.h", is_standard_include} : () -> () - // Generic form defining the inclusion of `"myheader"`. + // Custom form defining the inclusion of `"myheader"`. + emitc.include "myheader.h" + + // Generic form of the same operation. "emitc.include" (){include = "myheader.h"} : () -> () ``` }]; @@ -139,9 +142,8 @@ Arg:$include, UnitAttr:$is_standard_include ); - let assemblyFormat = [{ - $include attr-dict (`is_standard_include` $is_standard_include^)? - }]; + let printer = [{ return ::print(p, *this); }]; + let parser = [{ return ::parse$cppClass(parser, result); }]; let verifier = ?; } Index: mlir/lib/Dialect/EmitC/IR/EmitC.cpp =================================================================== --- mlir/lib/Dialect/EmitC/IR/EmitC.cpp +++ mlir/lib/Dialect/EmitC/IR/EmitC.cpp @@ -116,6 +116,38 @@ return value(); } +//===----------------------------------------------------------------------===// +// IncludeOp. +//===----------------------------------------------------------------------===// + +static void print(OpAsmPrinter &p, IncludeOp &op) { + bool standardInclude = op.is_standard_include(); + + p << IncludeOp::getOperationName() << " "; + if (standardInclude) + p << "<"; + p << "\"" << op.include() << "\""; + if (standardInclude) + p << ">"; +} + +static ParseResult parseIncludeOp(OpAsmParser &parser, OperationState &result) { + bool standardInclude = !parser.parseOptionalLess(); + + StringAttr include; + parser.parseAttribute(include, "include", result.attributes); + + if (standardInclude && parser.parseOptionalGreater()) + return parser.emitError(parser.getNameLoc()) + << "expected trailing '>' for standard include"; + + if (standardInclude) + result.addAttribute("is_standard_include", + UnitAttr::get(parser.getBuilder().getContext())); + + return success(); +} + //===----------------------------------------------------------------------===// // TableGen'd op method definitions //===----------------------------------------------------------------------===// Index: mlir/test/Dialect/EmitC/ops.mlir =================================================================== --- mlir/test/Dialect/EmitC/ops.mlir +++ mlir/test/Dialect/EmitC/ops.mlir @@ -1,7 +1,9 @@ -// RUN: mlir-opt -verify-diagnostics %s | FileCheck %s +// RUN: mlir-opt %s | FileCheck %s +// Verify the generic form can be parsed. +// RUN: mlir-opt -mlir-print-op-generic %s | mlir-opt -"emitc.include" (){include = "test.h", is_standard_include} : () -> () -emitc.include "test.h" is_standard_include +emitc.include <"test.h"> +emitc.include "test.h" // CHECK-LABEL: func @f(%{{.*}}: i32, %{{.*}}: !emitc.opaque<"int32_t">) { func @f(%arg0: i32, %f: !emitc.opaque<"int32_t">) {