Page MenuHomePhabricator

dosep.py: Add ability to set default test timout based on target
ClosedPublic

Authored by labath on Jun 17 2015, 6:25 PM.

Details

Summary

Current default is 10 minutes, which causes the test suite to run very long in
case of test timeouts. On linux, each test completes in under 90 seconds in the
slowest configuration (debug build of lldb, using debug clang to build
inferiors). So a default timeout of 4 minutes should suffice. If it turns out
to be not enough, we can fiddle with the number a bit.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 27907.Jun 17 2015, 6:25 PM
labath retitled this revision from to dosep.py: Add ability to set default test timout based on target.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: sivachandra, vharron.
labath added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.Jun 17 2015, 6:29 PM
sivachandra edited edge metadata.

I have no objections.

This revision is now accepted and ready to land.Jun 17 2015, 6:29 PM
vharron edited edge metadata.Jun 17 2015, 7:12 PM

Do remote tests pass in this time range? If not, maybe you should change
it to use 10 minutes for remote targets.

The time for the remote tests is heavily influenced by network latency. If the machines are close to each other, I believe the tests will pass (but I can't test it right now). For trans-oceanic tests, even 10m will not be enough...

This revision was automatically updated to reflect the committed changes.

I've set the default to 4m for local and 10m for remote targets.