diff --git a/libcxx/include/CMakeLists.txt b/libcxx/include/CMakeLists.txt --- a/libcxx/include/CMakeLists.txt +++ b/libcxx/include/CMakeLists.txt @@ -130,6 +130,9 @@ __iterator/ostreambuf_iterator.h __iterator/prev.h __iterator/projected.h + __iterator/ranges/advance.h + __iterator/ranges/next.h + __iterator/ranges/prev.h __iterator/readable_traits.h __iterator/reverse_iterator.h __iterator/wrap_iter.h diff --git a/libcxx/include/__iterator/advance.h b/libcxx/include/__iterator/advance.h --- a/libcxx/include/__iterator/advance.h +++ b/libcxx/include/__iterator/advance.h @@ -12,14 +12,8 @@ #include <__config> #include <__debug> -#include <__function_like.h> -#include <__iterator/concepts.h> -#include <__iterator/incrementable_traits.h> #include <__iterator/iterator_traits.h> -#include -#include #include -#include #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #pragma GCC system_header @@ -65,125 +59,6 @@ _VSTD::__advance(__i, __n, typename iterator_traits<_InputIter>::iterator_category()); } -#if !defined(_LIBCPP_HAS_NO_RANGES) - -namespace ranges { -// [range.iter.op.advance] -struct __advance_fn final : __function_like { -private: - template - static constexpr _Tp __abs(_Tp __n) noexcept { - return __n < 0 ? -__n : __n; - } - - template - static constexpr void __advance_forward(_Ip& __i, iter_difference_t<_Ip> __n) { - while (__n > 0) { - --__n; - ++__i; - } - } - - template - static constexpr void __advance_backward(_Ip& __i, iter_difference_t<_Ip> __n) { - while (__n < 0) { - ++__n; - --__i; - } - } - -public: - constexpr explicit __advance_fn(__tag __x) noexcept : __function_like(__x) {} - - // Preconditions: If `I` does not model `bidirectional_iterator`, `n` is not negative. - template - constexpr void operator()(_Ip& __i, iter_difference_t<_Ip> __n) const { - _LIBCPP_ASSERT(__n >= 0 || bidirectional_iterator<_Ip>, - "If `n < 0`, then `bidirectional_iterator` must be true."); - - // If `I` models `random_access_iterator`, equivalent to `i += n`. - if constexpr (random_access_iterator<_Ip>) { - __i += __n; - return; - } else if constexpr (bidirectional_iterator<_Ip>) { - // Otherwise, if `n` is non-negative, increments `i` by `n`. - __advance_forward(__i, __n); - // Otherwise, decrements `i` by `-n`. - __advance_backward(__i, __n); - return; - } else { - // Otherwise, if `n` is non-negative, increments `i` by `n`. - __advance_forward(__i, __n); - return; - } - } - - // Preconditions: Either `assignable_from || sized_sentinel_for` is modeled, or [i, bound) denotes a range. - template _Sp> - constexpr void operator()(_Ip& __i, _Sp __bound) const { - // If `I` and `S` model `assignable_from`, equivalent to `i = std::move(bound)`. - if constexpr (assignable_from<_Ip&, _Sp>) { - __i = std::move(__bound); - } - // Otherwise, if `S` and `I` model `sized_sentinel_for`, equivalent to `ranges::advance(i, bound - i)`. - else if constexpr (sized_sentinel_for<_Sp, _Ip>) { - (*this)(__i, __bound - __i); - } - // Otherwise, while `bool(i != bound)` is true, increments `i`. - else { - while (__i != __bound) { - ++__i; - } - } - } - - // Preconditions: - // * If `n > 0`, [i, bound) denotes a range. - // * If `n == 0`, [i, bound) or [bound, i) denotes a range. - // * If `n < 0`, [bound, i) denotes a range, `I` models `bidirectional_iterator`, and `I` and `S` model `same_as`. - // Returns: `n - M`, where `M` is the difference between the the ending and starting position. - template _Sp> - constexpr iter_difference_t<_Ip> operator()(_Ip& __i, iter_difference_t<_Ip> __n, _Sp __bound) const { - _LIBCPP_ASSERT(__n >= 0 || (bidirectional_iterator<_Ip> && same_as<_Ip, _Sp>), - "If `n < 0`, then `bidirectional_iterator && same_as` must be true."); - // If `S` and `I` model `sized_sentinel_for`: - if constexpr (sized_sentinel_for<_Sp, _Ip>) { - // If |n| >= |bound - i|, equivalent to `ranges::advance(i, bound)`. - if (const auto __M = __bound - __i; __abs(__n) >= __abs(__M)) { - (*this)(__i, __bound); - return __n - __M; - } - - // Otherwise, equivalent to `ranges::advance(i, n)`. - (*this)(__i, __n); - return 0; - } else { - // Otherwise, if `n` is non-negative, while `bool(i != bound)` is true, increments `i` but at - // most `n` times. - while (__i != __bound && __n > 0) { - ++__i; - --__n; - } - - // Otherwise, while `bool(i != bound)` is true, decrements `i` but at most `-n` times. - if constexpr (bidirectional_iterator<_Ip> && same_as<_Ip, _Sp>) { - while (__i != __bound && __n < 0) { - --__i; - ++__n; - } - } - return __n; - } - - _LIBCPP_UNREACHABLE(); - } -}; - -inline constexpr auto advance = __advance_fn(__function_like::__tag()); -} // namespace ranges - -#endif // !defined(_LIBCPP_HAS_NO_RANGES) - _LIBCPP_END_NAMESPACE_STD _LIBCPP_POP_MACROS diff --git a/libcxx/include/__iterator/next.h b/libcxx/include/__iterator/next.h --- a/libcxx/include/__iterator/next.h +++ b/libcxx/include/__iterator/next.h @@ -12,10 +12,7 @@ #include <__config> #include <__debug> -#include <__function_like.h> #include <__iterator/advance.h> -#include <__iterator/concepts.h> -#include <__iterator/incrementable_traits.h> #include <__iterator/iterator_traits.h> #include @@ -39,42 +36,6 @@ return __x; } -#if !defined(_LIBCPP_HAS_NO_RANGES) - -namespace ranges { -struct __next_fn final : private __function_like { - constexpr explicit __next_fn(__tag __x) noexcept : __function_like(__x) {} - - template - constexpr _Ip operator()(_Ip __x) const { - ++__x; - return __x; - } - - template - constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n) const { - ranges::advance(__x, __n); - return __x; - } - - template _Sp> - constexpr _Ip operator()(_Ip __x, _Sp __bound) const { - ranges::advance(__x, __bound); - return __x; - } - - template _Sp> - constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n, _Sp __bound) const { - ranges::advance(__x, __n, __bound); - return __x; - } -}; - -inline constexpr auto next = __next_fn(__function_like::__tag()); -} // namespace ranges - -#endif // !defined(_LIBCPP_HAS_NO_RANGES) - _LIBCPP_END_NAMESPACE_STD _LIBCPP_POP_MACROS diff --git a/libcxx/include/__iterator/prev.h b/libcxx/include/__iterator/prev.h --- a/libcxx/include/__iterator/prev.h +++ b/libcxx/include/__iterator/prev.h @@ -12,10 +12,7 @@ #include <__config> #include <__debug> -#include <__function_like.h> #include <__iterator/advance.h> -#include <__iterator/concepts.h> -#include <__iterator/incrementable_traits.h> #include <__iterator/iterator_traits.h> #include @@ -38,36 +35,6 @@ return __x; } -#if !defined(_LIBCPP_HAS_NO_RANGES) - -namespace ranges { -struct __prev_fn final : private __function_like { - constexpr explicit __prev_fn(__tag __x) noexcept : __function_like(__x) {} - - template - constexpr _Ip operator()(_Ip __x) const { - --__x; - return __x; - } - - template - constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n) const { - ranges::advance(__x, -__n); - return __x; - } - - template - constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n, _Ip __bound) const { - ranges::advance(__x, -__n, __bound); - return __x; - } -}; - -inline constexpr auto prev = __prev_fn(__function_like::__tag()); -} // namespace ranges - -#endif // !defined(_LIBCPP_HAS_NO_RANGES) - _LIBCPP_END_NAMESPACE_STD _LIBCPP_POP_MACROS diff --git a/libcxx/include/__iterator/advance.h b/libcxx/include/__iterator/ranges/advance.h copy from libcxx/include/__iterator/advance.h copy to libcxx/include/__iterator/ranges/advance.h --- a/libcxx/include/__iterator/advance.h +++ b/libcxx/include/__iterator/ranges/advance.h @@ -7,19 +7,17 @@ // //===----------------------------------------------------------------------===// -#ifndef _LIBCPP___ITERATOR_ADVANCE_H -#define _LIBCPP___ITERATOR_ADVANCE_H +#ifndef _LIBCPP___ITERATOR_RANGES_ADVANCE_H +#define _LIBCPP___ITERATOR_RANGES_ADVANCE_H #include <__config> #include <__debug> #include <__function_like.h> #include <__iterator/concepts.h> #include <__iterator/incrementable_traits.h> -#include <__iterator/iterator_traits.h> +#include <__utility/move.h> #include -#include #include -#include #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #pragma GCC system_header @@ -30,41 +28,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD -template -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 void -__advance(_InputIter& __i, typename iterator_traits<_InputIter>::difference_type __n, input_iterator_tag) { - for (; __n > 0; --__n) - ++__i; -} - -template -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 void -__advance(_BiDirIter& __i, typename iterator_traits<_BiDirIter>::difference_type __n, bidirectional_iterator_tag) { - if (__n >= 0) - for (; __n > 0; --__n) - ++__i; - else - for (; __n < 0; ++__n) - --__i; -} - -template -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 void -__advance(_RandIter& __i, typename iterator_traits<_RandIter>::difference_type __n, random_access_iterator_tag) { - __i += __n; -} - -template < - class _InputIter, class _Distance, - class = typename enable_if()))>::value>::type> -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 void advance(_InputIter& __i, _Distance __orig_n) { - typedef decltype(_VSTD::__convert_to_integral(__orig_n)) _IntegralSize; - _IntegralSize __n = __orig_n; - _LIBCPP_ASSERT(__n >= 0 || __is_cpp17_bidirectional_iterator<_InputIter>::value, - "Attempt to advance(it, n) with negative n on a non-bidirectional iterator"); - _VSTD::__advance(__i, __n, typename iterator_traits<_InputIter>::iterator_category()); -} - #if !defined(_LIBCPP_HAS_NO_RANGES) namespace ranges { @@ -188,4 +151,4 @@ _LIBCPP_POP_MACROS -#endif // _LIBCPP___ITERATOR_ADVANCE_H +#endif // _LIBCPP___ITERATOR_RANGES_ADVANCE_H diff --git a/libcxx/include/__iterator/next.h b/libcxx/include/__iterator/ranges/next.h copy from libcxx/include/__iterator/next.h copy to libcxx/include/__iterator/ranges/next.h --- a/libcxx/include/__iterator/next.h +++ b/libcxx/include/__iterator/ranges/next.h @@ -11,12 +11,10 @@ #define _LIBCPP___ITERATOR_NEXT_H #include <__config> -#include <__debug> #include <__function_like.h> -#include <__iterator/advance.h> #include <__iterator/concepts.h> #include <__iterator/incrementable_traits.h> -#include <__iterator/iterator_traits.h> +#include <__iterator/ranges/advance.h> #include #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) @@ -28,17 +26,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD -template -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 - typename enable_if<__is_cpp17_input_iterator<_InputIter>::value, _InputIter>::type - next(_InputIter __x, typename iterator_traits<_InputIter>::difference_type __n = 1) { - _LIBCPP_ASSERT(__n >= 0 || __is_cpp17_bidirectional_iterator<_InputIter>::value, - "Attempt to next(it, n) with negative n on a non-bidirectional iterator"); - - _VSTD::advance(__x, __n); - return __x; -} - #if !defined(_LIBCPP_HAS_NO_RANGES) namespace ranges { diff --git a/libcxx/include/__iterator/prev.h b/libcxx/include/__iterator/ranges/prev.h copy from libcxx/include/__iterator/prev.h copy to libcxx/include/__iterator/ranges/prev.h --- a/libcxx/include/__iterator/prev.h +++ b/libcxx/include/__iterator/ranges/prev.h @@ -11,12 +11,10 @@ #define _LIBCPP___ITERATOR_PREV_H #include <__config> -#include <__debug> #include <__function_like.h> -#include <__iterator/advance.h> #include <__iterator/concepts.h> #include <__iterator/incrementable_traits.h> -#include <__iterator/iterator_traits.h> +#include <__iterator/ranges/advance.h> #include #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) @@ -28,16 +26,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD -template -inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 - typename enable_if<__is_cpp17_input_iterator<_InputIter>::value, _InputIter>::type - prev(_InputIter __x, typename iterator_traits<_InputIter>::difference_type __n = 1) { - _LIBCPP_ASSERT(__n <= 0 || __is_cpp17_bidirectional_iterator<_InputIter>::value, - "Attempt to prev(it, n) with a positive n on a non-bidirectional iterator"); - _VSTD::advance(__x, -__n); - return __x; -} - #if !defined(_LIBCPP_HAS_NO_RANGES) namespace ranges { diff --git a/libcxx/include/__ranges/drop_view.h b/libcxx/include/__ranges/drop_view.h --- a/libcxx/include/__ranges/drop_view.h +++ b/libcxx/include/__ranges/drop_view.h @@ -12,6 +12,7 @@ #include <__config> #include <__iterator/iterator_traits.h> #include <__iterator/concepts.h> +#include <__iterator/ranges/next.h> #include <__ranges/access.h> #include <__ranges/view_interface.h> #include <__ranges/all.h> diff --git a/libcxx/include/__ranges/subrange.h b/libcxx/include/__ranges/subrange.h --- a/libcxx/include/__ranges/subrange.h +++ b/libcxx/include/__ranges/subrange.h @@ -13,7 +13,7 @@ #include <__iterator/concepts.h> #include <__iterator/incrementable_traits.h> #include <__iterator/iterator_traits.h> -#include <__iterator/advance.h> +#include <__iterator/ranges/advance.h> #include <__ranges/access.h> #include <__ranges/concepts.h> #include <__ranges/enable_borrowed_range.h> diff --git a/libcxx/include/__ranges/view_interface.h b/libcxx/include/__ranges/view_interface.h --- a/libcxx/include/__ranges/view_interface.h +++ b/libcxx/include/__ranges/view_interface.h @@ -12,7 +12,7 @@ #include <__config> #include <__iterator/concepts.h> #include <__iterator/iterator_traits.h> -#include <__iterator/prev.h> +#include <__iterator/ranges/prev.h> #include <__memory/pointer_traits.h> #include <__ranges/access.h> #include <__ranges/concepts.h> diff --git a/libcxx/include/iterator b/libcxx/include/iterator --- a/libcxx/include/iterator +++ b/libcxx/include/iterator @@ -576,6 +576,9 @@ #include <__iterator/ostreambuf_iterator.h> #include <__iterator/prev.h> #include <__iterator/projected.h> +#include <__iterator/ranges/advance.h> +#include <__iterator/ranges/next.h> +#include <__iterator/ranges/prev.h> #include <__iterator/readable_traits.h> #include <__iterator/reverse_iterator.h> #include <__iterator/wrap_iter.h> diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap --- a/libcxx/include/module.modulemap +++ b/libcxx/include/module.modulemap @@ -475,6 +475,23 @@ module readable_traits { header "__iterator/readable_traits.h" } module reverse_iterator { header "__iterator/reverse_iterator.h" } module wrap_iter { header "__iterator/wrap_iter.h" } + + module ranges { + module advance { + header "__iterator/ranges/advance.h" + export __function_like + } + + module next { + header "__iterator/ranges/next.h" + export __function_like + } + + module prev { + header "__iterator/ranges/prev.h" + export __function_like + } + } } } module latch { diff --git a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp --- a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp +++ b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/special_function.compile.pass.cpp @@ -9,8 +9,6 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: libcpp-no-concepts // UNSUPPORTED: gcc-10 -// XFAIL: clang-11 && modules-build -// XFAIL: clang-12 && modules-build // ranges::advance diff --git a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp --- a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp +++ b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp @@ -9,8 +9,6 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: libcpp-no-concepts // UNSUPPORTED: gcc-10 -// XFAIL: clang-11 && modules-build -// XFAIL: clang-12 && modules-build // ranges::next diff --git a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/special_function.compile.pass.cpp b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/special_function.compile.pass.cpp --- a/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/special_function.compile.pass.cpp +++ b/libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/special_function.compile.pass.cpp @@ -9,8 +9,6 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: libcpp-no-concepts // UNSUPPORTED: gcc-10 -// XFAIL: clang-11 && modules-build -// XFAIL: clang-12 && modules-build // ranges::prev