Page MenuHomePhabricator

Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2
AbandonedPublic

Authored by ki.stfu on Jun 16 2015, 3:42 PM.

Details

Reviewers
dawn
abidh
brucem
Summary

This patch should have gone in with svn rev.234476 - it is another refactoring for the handling of escapes and quotes. Note: Ilia is the original author for this patch. Commit message which applies to this patch from Ilia:

Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI)

Also it expands the variable value format for strings (aka char*):
was:
^done,name="v4",numchild="1",value="0x0000000100000f56",type="const char *",thread-id="1",has_more="0"

now:
^done,name="v4",numchild="1",value="0x0000000100000f56 \"ab\"",type="const char *",thread-id="1",has_more="0"

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 27787.Jun 16 2015, 3:42 PM
dawn retitled this revision from to Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2.
dawn updated this object.
dawn edited the test plan for this revision. (Show Details)
dawn added a reviewer: ki.stfu.
dawn set the repository for this revision to rL LLVM.
dawn updated this object.Jun 17 2015, 4:30 PM
dawn edited the test plan for this revision. (Show Details)
dawn added reviewers: abidh, brucem.
dawn added a subscriber: Unknown Object (MLST).
ki.stfu edited edge metadata.Jun 18 2015, 11:56 AM

I'm at conference until Monday and will take a look at it later.

dawn added a comment.Jun 22 2015, 1:50 PM

Please review? Thank you.

ki.stfu commandeered this revision.Jun 25 2015, 3:04 AM
ki.stfu edited reviewers, added: dawn; removed: ki.stfu.

I created a new patch for that: http://reviews.llvm.org/D10728.

ki.stfu planned changes to this revision.Jun 25 2015, 3:05 AM
ki.stfu abandoned this revision.