This is an archive of the discontinued LLVM Phabricator instance.

Differential D104375

[lldb] Don't try to set -Wno-deprecated-register
Needs ReviewPublic

Authored by teemperor on Jun 16 2021, 6:26 AM.

Details

Reviewers
JDevlieghere
Summary

This was added a long time ago to suppress warnings, but we aren't using register anymore in the code base so this can go.

Diff Detail

Event Timeline

teemperor created this revision.Jun 16 2021, 6:26 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 16 2021, 6:26 AM
teemperor requested review of this revision.Jun 16 2021, 6:26 AM
Harbormaster completed remote builds in B109500: Diff 352413.Jun 16 2021, 12:42 PM

Revision Contents

PathSize
lldb/
cmake/
modules/
3 lines

Diff 352413

lldb/cmake/modules/LLDBConfig.cmake

Show First 20 Lines • Show All 164 Lines • ▼ Show 20 Lines
check_cxx_compiler_flag("-Wno-unknown-pragmas" CXX_SUPPORTS_NO_UNKNOWN_PRAGMAS) check_cxx_compiler_flag("-Wno-unknown-pragmas" CXX_SUPPORTS_NO_UNKNOWN_PRAGMAS)
append_if(CXX_SUPPORTS_NO_UNKNOWN_PRAGMAS "-Wno-unknown-pragmas" CMAKE_CXX_FLAGS) append_if(CXX_SUPPORTS_NO_UNKNOWN_PRAGMAS "-Wno-unknown-pragmas" CMAKE_CXX_FLAGS)
check_cxx_compiler_flag("-Wno-strict-aliasing" CXX_SUPPORTS_NO_STRICT_ALIASING) check_cxx_compiler_flag("-Wno-strict-aliasing" CXX_SUPPORTS_NO_STRICT_ALIASING)
append_if(CXX_SUPPORTS_NO_STRICT_ALIASING "-Wno-strict-aliasing" CMAKE_CXX_FLAGS) append_if(CXX_SUPPORTS_NO_STRICT_ALIASING "-Wno-strict-aliasing" CMAKE_CXX_FLAGS)
# Disable Clang warnings # Disable Clang warnings
check_cxx_compiler_flag("-Wno-deprecated-register" CXX_SUPPORTS_NO_DEPRECATED_REGISTER)
append_if(CXX_SUPPORTS_NO_DEPRECATED_REGISTER "-Wno-deprecated-register" CMAKE_CXX_FLAGS)
check_cxx_compiler_flag("-Wno-vla-extension" CXX_SUPPORTS_NO_VLA_EXTENSION) check_cxx_compiler_flag("-Wno-vla-extension" CXX_SUPPORTS_NO_VLA_EXTENSION)
append_if(CXX_SUPPORTS_NO_VLA_EXTENSION "-Wno-vla-extension" CMAKE_CXX_FLAGS) append_if(CXX_SUPPORTS_NO_VLA_EXTENSION "-Wno-vla-extension" CMAKE_CXX_FLAGS)
# Disable MSVC warnings # Disable MSVC warnings
if( MSVC ) if( MSVC )
add_definitions( add_definitions(
-wd4018 # Suppress 'warning C4018: '>=' : signed/unsigned mismatch' -wd4018 # Suppress 'warning C4018: '>=' : signed/unsigned mismatch'
-wd4068 # Suppress 'warning C4068: unknown pragma' -wd4068 # Suppress 'warning C4068: unknown pragma'
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines