This is an archive of the discontinued LLVM Phabricator instance.

[SPARC] Legalize truncation and extension between fp128 and half
ClosedPublic

Authored by LemonBoy on Jun 12 2021, 11:08 AM.

Details

Summary

Lower truncations and expansions between fp128 and half values into libcalls.
Expand truncating stores into two separate truncation and a store operations.

Diff Detail

Event Timeline

LemonBoy created this revision.Jun 12 2021, 11:08 AM
LemonBoy requested review of this revision.Jun 12 2021, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2021, 11:08 AM

The diff looks fine but:

(a) the commit title only mentions truncstore whilst this also fixes both general truncation and extension
(b) the commit body doesn't mention extension

LemonBoy retitled this revision from [SPARC] Legalize truncating stores of fp128 to half values to [SPARC] Legalize truncation and extension between fp128 and half.Jun 12 2021, 11:18 AM
LemonBoy edited the summary of this revision. (Show Details)

The diff looks fine but:

(a) the commit title only mentions truncstore whilst this also fixes both general truncation and extension
(b) the commit body doesn't mention extension

I'm bad at picking titles,

The diff looks fine but:

(a) the commit title only mentions truncstore whilst this also fixes both general truncation and extension
(b) the commit body doesn't mention extension

Fixing the extension was a side-effect, I've now updated the commit title and body.

jrtc27 accepted this revision.Jun 12 2021, 11:20 AM
This revision is now accepted and ready to land.Jun 12 2021, 11:20 AM