Index: clang/lib/StaticAnalyzer/Core/BugReporter.cpp =================================================================== --- clang/lib/StaticAnalyzer/Core/BugReporter.cpp +++ clang/lib/StaticAnalyzer/Core/BugReporter.cpp @@ -1988,12 +1988,11 @@ const SourceManager &SM = getSourceManager(); const AnalyzerOptions &Opts = getAnalyzerOptions(); - StringRef ErrorTag = ErrorNode->getLocation().getTag()->getTagDescription(); // See whether we need to silence the checker/package. // FIXME: This will not work if the report was emitted with an incorrect tag. for (const std::string &CheckerOrPackage : Opts.SilencedCheckersAndPackages) { - if (ErrorTag.startswith(CheckerOrPackage)) + if (R->getBugType().getCheckerName().startswith(CheckerOrPackage)) return nullptr; } Index: clang/test/Analysis/malloc.cpp =================================================================== --- clang/test/Analysis/malloc.cpp +++ clang/test/Analysis/malloc.cpp @@ -1,7 +1,32 @@ -// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.CastSize,unix.Malloc,cplusplus.NewDelete -analyzer-store=region -verify %s -// RUN: %clang_analyze_cc1 -triple i386-unknown-linux-gnu -w -analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.CastSize,unix.Malloc,cplusplus.NewDelete -analyzer-store=region -verify %s -// RUN: %clang_analyze_cc1 -w -analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.CastSize,unix.Malloc,cplusplus.NewDelete -analyzer-store=region -DTEST_INLINABLE_ALLOCATORS -verify %s -// RUN: %clang_analyze_cc1 -triple i386-unknown-linux-gnu -w -analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.CastSize,unix.Malloc,cplusplus.NewDelete -analyzer-store=region -DTEST_INLINABLE_ALLOCATORS -verify %s +// RUN: %clang_analyze_cc1 -w -verify %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.deadcode.UnreachableCode \ +// RUN: -analyzer-checker=alpha.core.CastSize \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete + +// RUN: %clang_analyze_cc1 -w -verify %s \ +// RUN: -triple i386-unknown-linux-gnu \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.deadcode.UnreachableCode \ +// RUN: -analyzer-checker=alpha.core.CastSize \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete + +// RUN: %clang_analyze_cc1 -w -verify %s -DTEST_INLINABLE_ALLOCATORS \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.deadcode.UnreachableCode \ +// RUN: -analyzer-checker=alpha.core.CastSize \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete + +// RUN: %clang_analyze_cc1 -w -verify %s -DTEST_INLINABLE_ALLOCATORS \ +// RUN: -triple i386-unknown-linux-gnu \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=alpha.deadcode.UnreachableCode \ +// RUN: -analyzer-checker=alpha.core.CastSize \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete #include "Inputs/system-header-simulator-cxx.h" Index: clang/test/Analysis/silence-checkers-malloc.cpp =================================================================== --- /dev/null +++ clang/test/Analysis/silence-checkers-malloc.cpp @@ -0,0 +1,40 @@ +// RUN: %clang_analyze_cc1 -verify="no-silence" %s \ +// RUN: -triple i386-unknown-linux-gnu \ +// RUN: -analyzer-checker=core,apiModeling \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete + +// RUN: %clang_analyze_cc1 -verify="unix-silenced" %s \ +// RUN: -triple i386-unknown-linux-gnu \ +// RUN: -analyzer-checker=core,apiModeling \ +// RUN: -analyzer-checker=unix.Malloc \ +// RUN: -analyzer-checker=cplusplus.NewDelete\ +// RUN: -analyzer-config silence-checkers="unix" + +#include "Inputs/system-header-simulator-cxx.h" + +typedef __typeof(sizeof(int)) size_t; +void *malloc(size_t); +void free(void *); +void *realloc(void *ptr, size_t size); +void *calloc(size_t nmemb, size_t size); +char *strdup(const char *s); + +void checkThatMallocCheckerIsRunning() { + malloc(4); +} // no-silence-warning{{Potential memory leak [unix.Malloc]}} + +int const_ptr_and_callback_def_param_null(int, const char *, int n, void (*)(void *) = 0); +void r11160612_no_callback() { + char *x = (char *)malloc(12); + const_ptr_and_callback_def_param_null(0, x, 12); +} // no-silence-warning{{Potential leak of memory pointed to by 'x' [unix.Malloc]}} + +#define ZERO_SIZE_PTR ((void *)16) + +void test_delete_ZERO_SIZE_PTR() { + int *Ptr = (int *)ZERO_SIZE_PTR; + // ZERO_SIZE_PTR is specially handled but only for malloc family + delete Ptr; // no-silence-warning{{Argument to 'delete' is a constant address (16), which is not memory allocated by 'new' [cplusplus.NewDelete]}} + // unix-silenced-warning@-1{{Argument to 'delete' is a constant address (16), which is not memory allocated by 'new' [cplusplus.NewDelete]}} +}