diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp --- a/llvm/lib/Analysis/InlineCost.cpp +++ b/llvm/lib/Analysis/InlineCost.cpp @@ -390,7 +390,6 @@ bool visitPtrToInt(PtrToIntInst &I); bool visitIntToPtr(IntToPtrInst &I); bool visitCastInst(CastInst &I); - bool visitUnaryInstruction(UnaryInstruction &I); bool visitCmpInst(CmpInst &I); bool visitSub(BinaryOperator &I); bool visitBinaryOperator(BinaryOperator &I); @@ -1040,6 +1039,8 @@ } bool CallAnalyzer::visitAlloca(AllocaInst &I) { + disableSROA(I.getOperand(0)); + // Check whether inlining will turn a dynamic alloca into a static // alloca and handle that case. if (I.isArrayAllocation()) { @@ -1057,11 +1058,9 @@ AllocatedSize = SaturatingMultiplyAdd( AllocSize->getLimitedValue(), DL.getTypeAllocSize(Ty).getKnownMinSize(), AllocatedSize); - if (AllocatedSize > InlineConstants::MaxSimplifiedDynamicAllocaToInline) { + if (AllocatedSize > InlineConstants::MaxSimplifiedDynamicAllocaToInline) HasDynamicAlloca = true; - return false; - } - return Base::visitAlloca(I); + return false; } } @@ -1072,15 +1071,13 @@ SaturatingAdd(DL.getTypeAllocSize(Ty).getKnownMinSize(), AllocatedSize); } - // We will happily inline static alloca instructions. - if (I.isStaticAlloca()) - return Base::visitAlloca(I); - // FIXME: This is overly conservative. Dynamic allocas are inefficient for // a variety of reasons, and so we would like to not inline them into // functions which don't currently have a dynamic alloca. This simply // disables inlining altogether in the presence of a dynamic alloca. - HasDynamicAlloca = true; + if (!I.isStaticAlloca()) + HasDynamicAlloca = true; + return false; } @@ -1367,19 +1364,6 @@ TargetTransformInfo::TCC_Free; } -bool CallAnalyzer::visitUnaryInstruction(UnaryInstruction &I) { - Value *Operand = I.getOperand(0); - if (simplifyInstruction(I, [&](SmallVectorImpl &COps) { - return ConstantFoldInstOperands(&I, COps[0], DL); - })) - return true; - - // Disable any SROA on the argument to arbitrary unary instructions. - disableSROA(Operand); - - return false; -} - bool CallAnalyzer::paramHasAttr(Argument *A, Attribute::AttrKind Attr) { return CandidateCall.paramHasAttr(A->getArgNo(), Attr); }