diff --git a/lldb/source/Plugins/Process/elf-core/RegisterUtilities.h b/lldb/source/Plugins/Process/elf-core/RegisterUtilities.h --- a/lldb/source/Plugins/Process/elf-core/RegisterUtilities.h +++ b/lldb/source/Plugins/Process/elf-core/RegisterUtilities.h @@ -96,6 +96,9 @@ llvm::ArrayRef RegsetDescs); constexpr RegsetDesc FPR_Desc[] = { + // FreeBSD/i386 core NT_FPREGSET is x87 FSAVE result but the XSAVE dump + // starts with FXSAVE struct, so use that instead if available. + {llvm::Triple::FreeBSD, llvm::Triple::x86, llvm::ELF::NT_X86_XSTATE}, {llvm::Triple::FreeBSD, llvm::Triple::UnknownArch, llvm::ELF::NT_FPREGSET}, // In a i386 core file NT_FPREGSET is present, but it's not the result // of the FXSAVE instruction like in 64 bit files. diff --git a/lldb/test/Shell/Register/Core/x86-32-freebsd-addr.test b/lldb/test/Shell/Register/Core/x86-32-freebsd-addr.test --- a/lldb/test/Shell/Register/Core/x86-32-freebsd-addr.test +++ b/lldb/test/Shell/Register/Core/x86-32-freebsd-addr.test @@ -10,4 +10,7 @@ # CHECK-DAG: ds = 0x0000003b # CHECK-DAG: es = 0x0000003b -# TODO: fix reading fp registers +# CHECK-DAG: fiseg = 0x00000000 +# CHECK-DAG: fioff = 0x00401c52 +# CHECK-DAG: foseg = 0x00000000 +# CHECK-DAG: fooff = 0xffffd8b8 diff --git a/lldb/test/Shell/Register/Core/x86-32-freebsd-fp.test b/lldb/test/Shell/Register/Core/x86-32-freebsd-fp.test new file mode 100644 --- /dev/null +++ b/lldb/test/Shell/Register/Core/x86-32-freebsd-fp.test @@ -0,0 +1,3 @@ +# RUN: %lldb -b -s %s -c %p/Inputs/x86-32-freebsd.core | FileCheck %p/Inputs/x86-fp.check + +register read --all