Page MenuHomePhabricator

[mlir] Move PyConcreteAttribute to header. NFC.
ClosedPublic

Authored by ftynse on Apr 22 2021, 6:52 AM.

Details

Summary

This allows out-of-tree users to derive PyConcreteAttribute to bind custom
attributes.

Diff Detail

Event Timeline

ftynse created this revision.Apr 22 2021, 6:52 AM
ftynse requested review of this revision.Apr 22 2021, 6:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 6:52 AM
nicolasvasilache accepted this revision.Apr 22 2021, 7:02 AM
This revision is now accepted and ready to land.Apr 22 2021, 7:02 AM
This revision was landed with ongoing or failed builds.Apr 22 2021, 7:12 AM
This revision was automatically updated to reflect the committed changes.

Noted in the other thread: can you include this in the discourse discussion? (This was part of an ongoing discussion on the circt side and would be good to join)

jdd added a comment.Apr 22 2021, 3:37 PM

This is great, though IRModule.h isn't in the mlir include directory, so it's kinda awkward for out-of-tree users to #include it. Could it be moved? (Along with a few other header files in the python directory.)

I saw this, and agree this is great. I had the same question as John when I saw it. I've tested a branch of circt that included headers from this directory before, but I wasn't sure if they should move to the normal header directory eventually.