This is an archive of the discontinued LLVM Phabricator instance.

Fix SpecCPU2017's dependency from timeit-target to build-timeit-target
ClosedPublic

Authored by aqjune on Apr 18 2021, 5:59 PM.

Details

Summary

Building SpecCPU2017 using cmake raises this error:

CMake Error at External/SPEC/SpecCPU2017.cmake:263 (add_dependencies):                
  The dependency target "timeit-target" of target "imagevalidate_525-target"          
  does not exist.                                                                     
Call Stack (most recent call first):                                                  
  External/SPEC/CINT2017rate/525.x264_r/CMakeLists.txt:24 (speccpu2017_validate_image)

I think timeit-target should be build-timeit-target instead because cmake's progress output has this line:

[  3%] Built target build-timeit-target

Fixing this resolves the dependency error.

Diff Detail

Repository
rT test-suite

Event Timeline

aqjune created this revision.Apr 18 2021, 5:59 PM
aqjune requested review of this revision.Apr 18 2021, 5:59 PM
aqjune updated this revision to Diff 338405.Apr 18 2021, 6:02 PM

Remove irrelevant diffs

MaskRay accepted this revision.Jun 21 2021, 12:03 PM

LGTM.

This revision is now accepted and ready to land.Jun 21 2021, 12:03 PM