Page MenuHomePhabricator

Add ziglang builder
AbandonedPublic

Authored by infrandomness on Apr 16 2021, 11:38 AM.

Event Timeline

infrandomness created this revision.Apr 16 2021, 11:38 AM
infrandomness requested review of this revision.Apr 16 2021, 11:38 AM

Fix unwanted indentation modifications and use ZigBuilder

  • Correct typos

How long do these tests take to run? Could you add this to the list of release builders too?

How long do these tests take to run?

Generally about an hour on my server

Could you add this to the list of release builders too?

I am not quite sure how to do that;

Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?

buildbot/osuosl/master/config/builders.py
35–50

Those indentation changes are an oopsie, I am reverting them back

Hello Brice,

Thanks for the patch.

Please see my comments inline.

buildbot/osuosl/master/config/builders.py
25

This is an unrelated cosmetic change. Please remove.

zorg/buildbot/builders/ZigBuilder.py
8

Is there anything missing in zorg.buildbot.commands.CmakeCommand for your usage?

9

This should be

from zorg.buildbot.process.factory import LLVMBuildFactory
15

This is more for historical reasons and for backward compatibility. It is better to use jobs property instead, which is defined for your worker, as the number of jobs is more related to a particular worker hardware than to the builder itself.

81

It seems zorg.buildbot.commands.NinjaCommand should work for you here and in all other places where you run ninja. It will handle the jobs and loadaverage properties properly, and specifies a specific output format.

94

Is this a correct description? The command suggests that you run zig, not ninja.

How long do these tests take to run?

Generally about an hour on my server

Could you add this to the list of release builders too?

I am not quite sure how to do that;

There are examples in buildbot/osuosl/master/config/release_builders.py

Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?

I'm not sure I understand the question. You should have to rebuild llvm, clang, and lld for every commit.

Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?

If I get the question right, you will build incrementally unless you remove the build directory content for each build, which specified clean=True, does.
Remove that and you will reuse the results of the previous build with all pros and cons.

Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?

If I get the question right, you will build incrementally unless you remove the build directory content for each build, which specified clean=True, does.
Remove that and you will reuse the results of the previous build with all pros and cons.

Oh, right, will apply new changes

How long do these tests take to run?

Generally about an hour on my server

Could you add this to the list of release builders too?

I am not quite sure how to do that;

There are examples in buildbot/osuosl/master/config/release_builders.py

Will do

If this is fine with you, let's finish this patch first, stage the builder to make sure it is reliably green, then you could move it to the production build bot and add to the release_builders.py.

  • Remove unrelated cosmetics
  • Fix imports
  • Remove jobs
  • Replace the factories