Page MenuHomePhabricator

Separate Machine IR from CodeGen: Move SplitCriticalEdge out of MachineBasicBlock
Needs ReviewPublic

Authored by arphaman on May 27 2015, 9:49 AM.

Details

Summary

This patch is related to my proposal for separating machine IR from CodeGen: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-May/086063.html.

This patch moves the SplitCriticalEdge method out of MachineBasicBlock class so that MachineBasicBlock.cpp won't have to include several header
files that declare passes that won't be moved from CodeGen to the new Machine IR library.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman updated this revision to Diff 26608.May 27 2015, 9:49 AM
arphaman retitled this revision from to Separate Machine IR from CodeGen: Move SplitCriticalEdge out of MachineBasicBlock.
arphaman updated this object.
arphaman edited the test plan for this revision. (Show Details)
arphaman added reviewers: dexonsmith, bogner, bob.wilson.
arphaman set the repository for this revision to rL LLVM.
arphaman added a subscriber: Unknown Object (MLST).
arphaman updated this revision to Diff 26619.May 27 2015, 11:33 AM

I've updated the patch based on Duncan's comments:

  • Renamed the cpp + header files 'MachineIRUtils' to 'SplitCriticalEdge'
  • Fixed the function's name (it starts with lowercase now)
  • Got rid of unnecessary namespace
  • Fixed the function's comment