diff --git a/mlir/include/mlir/Conversion/LinalgToStandard/LinalgToStandard.h b/mlir/include/mlir/Conversion/LinalgToStandard/LinalgToStandard.h --- a/mlir/include/mlir/Conversion/LinalgToStandard/LinalgToStandard.h +++ b/mlir/include/mlir/Conversion/LinalgToStandard/LinalgToStandard.h @@ -29,7 +29,7 @@ // function. The implementation of the function can be either in the same module // or in an externally linked library. // This is a generic entry point for all LinalgOp, except for CopyOp and -// IndexedGenericOp, for which omre specialized patterns are provided. +// IndexedGenericOp, for which more specialized patterns are provided. class LinalgOpToLibraryCallRewrite : public OpInterfaceRewritePattern { public: diff --git a/mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp b/mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp --- a/mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp +++ b/mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp @@ -106,14 +106,12 @@ if (isa(op) || isa(op)) return failure(); - // TODO: remove once index ops are supported. - if (op.hasIndexSemantics()) - return failure(); - auto libraryCallName = getLibraryCallSymbolRef(op, rewriter); if (!libraryCallName) return failure(); + // TODO: Add support for more complex library call signatures that include + // indices or captured values. rewriter.replaceOpWithNewOp( op, libraryCallName.getValue(), TypeRange(), createTypeCanonicalizedMemRefOperands(rewriter, op->getLoc(),