Page MenuHomePhabricator

[lldb] Simplify output for skipped categories in dotest.py
ClosedPublic

Authored by JDevlieghere on Apr 14 2021, 2:01 PM.

Details

Summary

Print a single line listing all the categories that are being skipped, rather than relying on the check.*Support() functions specifying why a particular category will be skipped. If we know why a category got skipped, still print that in verbose mode.

The motivation for this change is that sometimes engineers misidentify the output of these messages as the cause for a test failure (e.g. not being able to build libc++ or libstdc++).

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Apr 14 2021, 2:01 PM
JDevlieghere created this revision.
JDevlieghere edited the summary of this revision. (Show Details)
mgorny accepted this revision.Apr 14 2021, 2:08 PM

I actually like the verbose output but I guess being more terse by default's fine.

This revision is now accepted and ready to land.Apr 14 2021, 2:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2021, 6:51 PM

The motivation for this change is that sometimes engineers misidentify the output of these messages as the cause for a test failure

I have worked on one these checks and *still* gotten confused by the message, so thanks :)