diff --git a/libcxx/include/__iterator/concepts.h b/libcxx/include/__iterator/concepts.h --- a/libcxx/include/__iterator/concepts.h +++ b/libcxx/include/__iterator/concepts.h @@ -127,7 +127,17 @@ incrementable<_Ip> && sentinel_for<_Ip, _Ip>; -// clang-format on +// [iterator.concept.bidir] +template +concept bidirectional_iterator = + forward_iterator<_Ip> && + derived_from<_ITER_CONCEPT<_Ip>, bidirectional_iterator_tag> && + requires(_Ip __i) { + { --__i } -> same_as<_Ip&>; + { __i-- } -> same_as<_Ip>; + }; + + // clang-format on #endif // !defined(_LIBCPP_HAS_NO_RANGES) diff --git a/libcxx/include/__ranges/concepts.h b/libcxx/include/__ranges/concepts.h --- a/libcxx/include/__ranges/concepts.h +++ b/libcxx/include/__ranges/concepts.h @@ -58,8 +58,10 @@ concept forward_range = input_range<_Tp> && forward_iterator >; template - concept common_range = range<_Tp> && same_as, sentinel_t<_Tp> >; + concept bidirectional_range = forward_range<_Tp> && bidirectional_iterator >; + template + concept common_range = range<_Tp> && same_as, sentinel_t<_Tp> >; } // namespace ranges #endif // !defined(_LIBCPP_HAS_NO_RANGES) diff --git a/libcxx/include/iterator b/libcxx/include/iterator --- a/libcxx/include/iterator +++ b/libcxx/include/iterator @@ -83,6 +83,10 @@ template concept forward_iterator = see below; // since C++20 +// [iterator.concept.bidir], concept bidirectional_iterator +template + concept bidirectional_­iterator = see below; // since C++20 + template struct iterator diff --git a/libcxx/include/ranges b/libcxx/include/ranges --- a/libcxx/include/ranges +++ b/libcxx/include/ranges @@ -54,6 +54,9 @@ template concept forward_range = see below; + template + concept bidirectional_­range = see below; + template concept common_range = see below; } diff --git a/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/associative/multimap/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/associative/multimap/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/associative/multimap/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/associative/multimap/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/associative/multiset/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/associative/multiset/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/associative/multiset/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/associative/multiset/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/deque/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/deque/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/deque/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/deque/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/forwardlist/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/forwardlist/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/forwardlist/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/forwardlist/range_concept_conformance.compile.pass.cpp @@ -24,7 +24,9 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/list/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/list/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/list/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/list/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/vector.bool/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/vector.bool/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/vector.bool/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/vector.bool/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/sequences/vector/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/sequences/vector/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/sequences/vector/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/sequences/vector/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/unord/unord.map/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/unord/unord.map/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/unord/unord.map/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/unord/unord.map/range_concept_conformance.compile.pass.cpp @@ -24,7 +24,9 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/unord/unord.multimap/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/unord/unord.multimap/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/unord/unord.multimap/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/unord/unord.multimap/range_concept_conformance.compile.pass.cpp @@ -24,7 +24,9 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/unord/unord.multiset/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/unord/unord.multiset/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/unord/unord.multiset/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/unord/unord.multiset/range_concept_conformance.compile.pass.cpp @@ -24,7 +24,9 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/unord/unord.set/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/unord/unord.set/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/unord/unord.set/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/unord/unord.set/range_concept_conformance.compile.pass.cpp @@ -24,7 +24,9 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); static_assert(std::same_as, range::const_iterator>); static_assert(stdr::common_range); static_assert(stdr::forward_range); +static_assert(!stdr::bidirectional_range); diff --git a/libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp @@ -23,8 +23,8 @@ static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, range::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/input.output/filesystems/class.path/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/input.output/filesystems/class.path/range_concept_conformance.compile.pass.cpp --- a/libcxx/test/std/input.output/filesystems/class.path/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/input.output/filesystems/class.path/range_concept_conformance.compile.pass.cpp @@ -22,8 +22,8 @@ static_assert(std::same_as, fs::path::iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); static_assert(std::same_as, fs::path::const_iterator>); static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(stdr::bidirectional_range); diff --git a/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/bidirectional_iterator.compile.pass.cpp b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/bidirectional_iterator.compile.pass.cpp new file mode 100644 --- /dev/null +++ b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/bidirectional_iterator.compile.pass.cpp @@ -0,0 +1,150 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +// UNSUPPORTED: c++03, c++11, c++14, c++17 +// UNSUPPORTED: libcpp-no-concepts +// UNSUPPORTED: gcc-10 +// XFAIL: msvc && clang + +// template +// concept bidirectional_iterator; + +#include + +#include + +#include "test_iterators.h" + +static_assert(!std::bidirectional_iterator >); +static_assert(!std::bidirectional_iterator >); +static_assert(!std::bidirectional_iterator >); +static_assert(std::bidirectional_iterator >); +static_assert(std::bidirectional_iterator >); +static_assert(std::bidirectional_iterator >); + + +static_assert(std::bidirectional_iterator); +static_assert(std::bidirectional_iterator); +static_assert(std::bidirectional_iterator); +static_assert(std::bidirectional_iterator); + +struct not_forward_iterator { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::bidirectional_iterator_tag; + + value_type operator*() const; + + not_forward_iterator& operator++(); + not_forward_iterator operator++(int); + + not_forward_iterator& operator--(); + not_forward_iterator& operator--(int); +}; +static_assert(std::input_iterator && !std::forward_iterator && + !std::bidirectional_iterator); + +struct wrong_iterator_category { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_category = std::forward_iterator_tag; + + value_type& operator*() const; + + wrong_iterator_category& operator++(); + wrong_iterator_category operator++(int); + + wrong_iterator_category& operator--(); + wrong_iterator_category operator--(int); + + bool operator==(wrong_iterator_category const&) const = default; +}; +static_assert(!std::bidirectional_iterator); + +struct wrong_iterator_concept { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::forward_iterator_tag; + + value_type& operator*() const; + + wrong_iterator_concept& operator++(); + wrong_iterator_concept operator++(int); + + wrong_iterator_concept& operator--(); + wrong_iterator_concept operator--(int); + + bool operator==(wrong_iterator_concept const&) const = default; +}; +static_assert(!std::bidirectional_iterator); + +struct no_predecrement { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::bidirectional_iterator_tag; + + value_type& operator*() const; + + no_predecrement& operator++(); + no_predecrement operator++(int); + + no_predecrement operator--(int); + + bool operator==(no_predecrement const&) const = default; +}; +static_assert(!std::bidirectional_iterator); + +struct bad_predecrement { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::bidirectional_iterator_tag; + + value_type& operator*() const; + + bad_predecrement& operator++(); + bad_predecrement operator++(int); + + bad_predecrement operator--(); + bad_predecrement operator--(int); + + bool operator==(bad_predecrement const&) const = default; +}; +static_assert(!std::bidirectional_iterator); + +struct no_postdecrement { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::bidirectional_iterator_tag; + + value_type& operator*() const; + + no_postdecrement& operator++(); + no_postdecrement operator++(int); + + no_postdecrement& operator--(); + + bool operator==(no_postdecrement const&) const = default; +}; +static_assert(!std::bidirectional_iterator); + +struct bad_postdecrement { + using value_type = int; + using difference_type = std::ptrdiff_t; + using iterator_concept = std::bidirectional_iterator_tag; + + value_type& operator*() const; + + bad_postdecrement& operator++(); + bad_postdecrement operator++(int); + + bad_postdecrement& operator--(); + bad_postdecrement& operator--(int); + + bool operator==(bad_postdecrement const&) const = default; +}; +static_assert(!std::bidirectional_iterator); diff --git a/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/subsumption.compile.pass.cpp copy from libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp copy to libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/subsumption.compile.pass.cpp --- a/libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp +++ b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.bidir/subsumption.compile.pass.cpp @@ -11,20 +11,24 @@ // UNSUPPORTED: gcc-10 // XFAIL: msvc && clang -// map +// template +// concept bidirectional_iterator; -#include +#include #include -#include -using range = std::map; -namespace stdr = std::ranges; +// clang-format off +template +requires std::derived_from, std::bidirectional_iterator_tag> +[[nodiscard]] constexpr bool check_subsumption() { + return false; +} -static_assert(std::same_as, range::iterator>); -static_assert(stdr::common_range); -static_assert(stdr::forward_range); +template +[[nodiscard]] constexpr bool check_subsumption() { + return true; +} +// clang-format on -static_assert(std::same_as, range::const_iterator>); -static_assert(stdr::common_range); -static_assert(stdr::forward_range); +static_assert(check_subsumption()); diff --git a/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.forward/forward_iterator.compile.pass.cpp b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.forward/forward_iterator.compile.pass.cpp --- a/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.forward/forward_iterator.compile.pass.cpp +++ b/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.forward/forward_iterator.compile.pass.cpp @@ -19,13 +19,13 @@ #include "test_iterators.h" +static_assert(!std::forward_iterator >); +static_assert(!std::forward_iterator >); static_assert(std::forward_iterator >); static_assert(std::forward_iterator >); static_assert(std::forward_iterator >); static_assert(std::forward_iterator >); -// TODO: add new `cxx20_*_iterator`s as they're added -static_assert(!std::forward_iterator >); static_assert(std::forward_iterator); static_assert(std::forward_iterator); diff --git a/libcxx/test/std/ranges/range.refinements/bidirectional_range.compile.pass.cpp b/libcxx/test/std/ranges/range.refinements/bidirectional_range.compile.pass.cpp new file mode 100644 --- /dev/null +++ b/libcxx/test/std/ranges/range.refinements/bidirectional_range.compile.pass.cpp @@ -0,0 +1,41 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +// UNSUPPORTED: c++03, c++11, c++14, c++17 +// UNSUPPORTED: libcpp-no-concepts +// UNSUPPORTED: gcc-10 +// XFAIL: msvc && clang + +// template +// concept bidirectional_range; + +#include + +#include "test_range.h" + +namespace stdr = std::ranges; + +template