Page MenuHomePhabricator

Recent Activity

Today

MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@rnk @amccarth Do you have more comments? ☺️

Sun, Sep 20, 10:38 AM · Restricted Project, lld, Restricted Project
MaskRay requested changes to D87121: LLD symbol ordering file binary name tag.
Sun, Sep 20, 10:34 AM
MaskRay accepted D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Sun, Sep 20, 10:33 AM · Restricted Project, Restricted Project
EccoTheDolphin added inline comments to D87579: [RISCV][ASAN] unwind fixup.
Sun, Sep 20, 10:33 AM · Restricted Project
MaskRay accepted D80367: [RISCV][MC] Print absolute targets of branch instructions.

This may require rebasing but the idea looks great to me.

Sun, Sep 20, 10:33 AM · Restricted Project
dougpuob added a comment to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

Hi @aaron.ballman
About changing size_t nLength to cbLength. I searched MSVC folders with size_t, many names of variable start with n, or i in MFC related files. So I prefer to keep it starts with n. Another side to name starts with cb, I found variables like cbXxx are defined with ULONG, DWORD, or UCHAR type.

Sun, Sep 20, 10:24 AM · Restricted Project, Restricted Project
MaskRay added a comment to D87953: [xray] Function coverage groups.

The idea seems fine.

Sun, Sep 20, 10:22 AM · Restricted Project
CarolineConcatto updated the summary of D87125: Update recipe for flang-aarch64 slaves.
Sun, Sep 20, 10:12 AM
CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Update compile location for flang-aarch64-ubuntu{clang and gcc10}

Sun, Sep 20, 10:11 AM
xbolva00 added a comment to rG7903ae4720a8: [InstCombine] factorize left shifts of add/sub.

Thanks, great! :)

Sun, Sep 20, 10:07 AM
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sun, Sep 20, 10:02 AM · Restricted Project, Restricted Project
spatel committed rG7903ae4720a8: [InstCombine] factorize left shifts of add/sub (authored by spatel).
[InstCombine] factorize left shifts of add/sub
Sun, Sep 20, 10:00 AM
lebedev.ri added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

(I'm guessing that we are talking about run-time performance here.)

Sun, Sep 20, 9:57 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sun, Sep 20, 9:51 AM · Restricted Project, Restricted Project
MaskRay added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sun, Sep 20, 9:46 AM · Restricted Project, Restricted Project
RKSimon added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sun, Sep 20, 9:46 AM
Higuoxing added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sun, Sep 20, 9:44 AM
MaskRay updated subscribers of D87985: fix bug when adrp_imm < 0.
Sun, Sep 20, 9:35 AM · Restricted Project
MaskRay updated subscribers of D87985: fix bug when adrp_imm < 0.

Thanks for identifying the bug. SymbolierSymbolLookup is used as a parameter of llvm::Target::createMCSymbolizer. The information is very low level and duplicates the normal operand decoding logic by lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp DecodeAdrInstruction. The latter is used ubiquitously while the former (SymbolierSymbolLookup) is used in very few places and less tested. There are only 3 tests failing if I change the argument of createMCSymbolizer to nullptr:

Sun, Sep 20, 9:32 AM · Restricted Project
spatel committed rGcf75e83275d1: [InstCombine] replace zombie unreachable values with 'undef' before erasing (authored by spatel).
[InstCombine] replace zombie unreachable values with 'undef' before erasing
Sun, Sep 20, 9:25 AM
spatel closed D87965: [InstCombine] replace phi values from unreachable blocks with 'undef'.
Sun, Sep 20, 9:25 AM · Restricted Project
spatel added inline comments to D87965: [InstCombine] replace phi values from unreachable blocks with 'undef'.
Sun, Sep 20, 9:24 AM · Restricted Project
xbolva00 retitled D87988: [SystemZ] Optimize bcmp calls (PR47420) from [SystemZ] Optimize bcmp calls to [SystemZ] Optimize bcmp calls (PR47420).
Sun, Sep 20, 9:21 AM · Restricted Project
xbolva00 requested review of D87988: [SystemZ] Optimize bcmp calls (PR47420).
Sun, Sep 20, 9:19 AM · Restricted Project
xbolva00 committed rG2ae182258c49: [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof… (authored by xbolva00).
[Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof…
Sun, Sep 20, 8:43 AM
MaskRay added a comment to D87985: fix bug when adrp_imm < 0.

"Add Action..." -> "Close Revision". However, if you just want to update the existing Differential, you can click "Upload Diff" or use arc diff 'HEAD^' (if the last commit has the Differential Revision: string connecting to this differential.

Sun, Sep 20, 8:40 AM · Restricted Project
RKSimon committed rG15c8306056be: [X86][SSE] Fold EXTEND_VECTOR_INREG(EXTEND_VECTOR_INREG(X)) ->… (authored by RKSimon).
[X86][SSE] Fold EXTEND_VECTOR_INREG(EXTEND_VECTOR_INREG(X)) ->…
Sun, Sep 20, 8:35 AM
RKSimon committed rGa0c8793ce691: [X86][SSE] Enable ZERO_EXTEND_VECTOR_INREG shuffle combining on SSE41 targets. (authored by RKSimon).
[X86][SSE] Enable ZERO_EXTEND_VECTOR_INREG shuffle combining on SSE41 targets.
Sun, Sep 20, 8:05 AM
aaron.ballman added inline comments to D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body..
Sun, Sep 20, 7:45 AM · Restricted Project, Restricted Project
RKSimon committed rG2b634a9d0e14: [X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI. (authored by RKSimon).
[X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI.
Sun, Sep 20, 7:22 AM
RKSimon committed rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI. (authored by RKSimon).
DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI.
Sun, Sep 20, 7:22 AM
RKSimon accepted D87863: [X86] Make reduceMaskedLoadToScalarLoad/reduceMaskedStoreToScalarStore work for avx512 after type legalization..

LGTM

Sun, Sep 20, 6:27 AM · Restricted Project
RKSimon committed rG91720ee561b2: [X86] combineX86ShufflesRecursively - fix use after move warning. NFCI. (authored by RKSimon).
[X86] combineX86ShufflesRecursively - fix use after move warning. NFCI.
Sun, Sep 20, 6:18 AM
lebedev.ri accepted D87965: [InstCombine] replace phi values from unreachable blocks with 'undef'.

lg

Sun, Sep 20, 6:02 AM · Restricted Project
RKSimon committed rGa735d6eae284: JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI. (authored by RKSimon).
JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI.
Sun, Sep 20, 6:01 AM
spatel updated the diff for D87965: [InstCombine] replace phi values from unreachable blocks with 'undef'.

Patch updated:

  1. Use the direct approach to fix the bug - replace with undef before trying to delete.
  2. Avoid branch on undef in crashing test case.
Sun, Sep 20, 5:53 AM · Restricted Project
xbolva00 committed rG2990518b0324: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument (authored by xbolva00).
[MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument
Sun, Sep 20, 5:02 AM
xbolva00 added a comment to D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.

Thanks!

Sun, Sep 20, 5:02 AM · Restricted Project
xbolva00 closed D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sun, Sep 20, 5:02 AM · Restricted Project
fhahn accepted D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.

LGTM, thanks for also improving the test case!

Sun, Sep 20, 4:56 AM · Restricted Project