The new test cases in loops.mlir duplicate the existing tests for the indexed_generic operation (below). The code after lowering is the same the only difference is the input code (linalg.generic + linalg.index instead of linalg.indexed_generic).
Address Florian and Pengfei's comments.
(apologies for the review spam, you're the author of the test in this case)
looks great, just fix the build errors :)
Ok, looks good!
Interesting. Do we have near term plans for adding the Attributor to the default pass pipeline ?
Thanks for the fix! Do you have commit access?
Is this better?
I updated this patch to address comments & added a few examples that I concern.
I hope this helps check whether my understanding about pointer capture is correct.
@myhsu when you get a moment, can you check that this is all OK now? :)
I like the test coverage but I believe that we should get @CaseyCarter on board to port the ranges test machinery over. It is quite extensive and rebuilding it for the fun of it seems a waste of time
Ah sorry I came up with a repro but didn't find this phab review earlier. https://crbug.com/1198356#c1
Address comments, add a few examples
Trying to reword my thinking a little more clearly.
Can you add a testcase?
LGTM. But wait one or two days to see if there is more comments from Craig and HJ.