Page MenuHomePhabricator

Recent Activity

Today

gulfem added reviewers for D126586: [InstrProf][WIP] Implement boolean counters in coverage: phosek, paulkirth, abrachet.
Fri, May 27, 8:26 PM · Restricted Project, Restricted Project
gulfem updated the summary of D126586: [InstrProf][WIP] Implement boolean counters in coverage.
Fri, May 27, 8:23 PM · Restricted Project, Restricted Project
klausler requested review of D126587: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association.
Fri, May 27, 8:23 PM · Restricted Project, Restricted Project
gulfem requested review of D126586: [InstrProf][WIP] Implement boolean counters in coverage.
Fri, May 27, 8:22 PM · Restricted Project, Restricted Project
JamesNagurne added a comment to D121838: Generalize "check-all" umbrella targets, use for check-clang-tools.

After some investigation, I found that we did not set LLVM_INCLUDE_TESTS from the top-level project. This seems like an oversight because we build the test-depends (and check-all) regularly.
After seeing LLVM_INCLUDE_TESTS to ON, the builds worked.

This commit cleaned things up and exposed that mistake.

Fri, May 27, 8:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added reviewers for D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build.: bondhugula, mehdi_amini.
Fri, May 27, 8:19 PM · Restricted Project, Restricted Project
stellaraccident requested review of D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..
Fri, May 27, 8:19 PM · Restricted Project, Restricted Project
klausler requested review of D126584: [flang] Avoid spurious warnings from reading module files.
Fri, May 27, 8:18 PM · Restricted Project, Restricted Project
springerm committed rG2f0a634c5e80: [mlir][bufferization] Add extra filter mechanism to bufferizeOp (authored by springerm).
[mlir][bufferization] Add extra filter mechanism to bufferizeOp
Fri, May 27, 7:53 PM · Restricted Project, Restricted Project
springerm closed D126569: [mlir][bufferization] Add extra filter mechanism to bufferizeOp.
Fri, May 27, 7:52 PM · Restricted Project, Restricted Project
springerm committed rGf470f8cbcefd: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization (authored by springerm).
[mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization
Fri, May 27, 7:48 PM · Restricted Project, Restricted Project
springerm closed D126572: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization.
Fri, May 27, 7:47 PM · Restricted Project, Restricted Project
springerm committed rG3490aadf56c9: [mlir][bufferization][NFC] Remove post-analysis step infrastructure (authored by springerm).
[mlir][bufferization][NFC] Remove post-analysis step infrastructure
Fri, May 27, 7:40 PM · Restricted Project, Restricted Project
springerm closed D126571: [mlir][bufferization][NFC] Remove post-analysis step infrastructure.
Fri, May 27, 7:40 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Add chains.

Fri, May 27, 7:35 PM · Restricted Project, Restricted Project
abrachet accepted D126582: [scudo] Clean up Zircon header file uses.
Fri, May 27, 7:17 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D126583: [libcxx] Minor emscripten changes from downstream: ldionne.
Fri, May 27, 7:14 PM · Restricted Project, Restricted Project
sbc100 requested review of D126583: [libcxx] Minor emscripten changes from downstream.
Fri, May 27, 7:13 PM · Restricted Project, Restricted Project
NimishMishra updated the summary of D125668: [flang][OpenMP] Lowering support for atomic update construct.
Fri, May 27, 7:12 PM · Restricted Project, Restricted Project, Restricted Project
NimishMishra accepted D125793: [flang][OpenMP] Fix pointer variables in atomic read/write.

LGTM

Fri, May 27, 7:08 PM · Restricted Project, Restricted Project
NimishMishra updated the summary of D123930: [flang][OpenMP] Lowering support for default clause.
Fri, May 27, 7:00 PM · Restricted Project, Restricted Project, Restricted Project
peixin added a comment to D126556: [OpenMP][mlir] fix broken build.

Thanks for fix this. Sorry to bother you.

Fri, May 27, 6:59 PM · Restricted Project, Restricted Project
NimishMishra updated the summary of D123930: [flang][OpenMP] Lowering support for default clause.
Fri, May 27, 6:59 PM · Restricted Project, Restricted Project, Restricted Project
mcgrathr requested review of D126582: [scudo] Clean up Zircon header file uses.
Fri, May 27, 6:33 PM · Restricted Project, Restricted Project
Allen updated the diff for D126532: [SVE] Add a DAG combiner fold to visitADD for vscale with truncate.
Fri, May 27, 6:33 PM · Restricted Project, Restricted Project
rsmith accepted D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`..

OK, fair enough.

Fri, May 27, 6:04 PM · Restricted Project, Restricted Project
vsapsai added a comment to D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`..

For the record, FunctionTemplate case was added in https://reviews.llvm.org/rG9359e8f22a5403ad9524a92c4ccab4db46c9c100

Fri, May 27, 6:01 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D125622: [clang-tidy] Reject invalid enum initializers in C files.
  • Add C++ test case for acceptable operator, initializer
Fri, May 27, 5:55 PM · Restricted Project, Restricted Project
LegalizeAdulthood added inline comments to D125622: [clang-tidy] Reject invalid enum initializers in C files.
Fri, May 27, 5:52 PM · Restricted Project, Restricted Project
LegalizeAdulthood updated the diff for D125622: [clang-tidy] Reject invalid enum initializers in C files.
  • Update from review comments
  • Disallow operator, unless inside parentheses
Fri, May 27, 5:43 PM · Restricted Project, Restricted Project
rnk requested review of D126581: [Bazel][GN] Reuse the GN LLVM config file generation code.
Fri, May 27, 5:29 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Comments

Fri, May 27, 5:18 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D126230: [mlir] Add global_load and global_store ops to ml_program..
Fri, May 27, 5:18 PM · Restricted Project, Restricted Project
vitalybuka requested changes to D126100: Add sanitizer-specific GlobalValue attributes..

all stuff under llvm/... here needs testing, Bitcode and AsmParser have many tests usable as examples

Fri, May 27, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
paulkirth requested review of D126580: [compiler-rt] Avoid truncating Symbolizer output.
Fri, May 27, 5:03 PM · Restricted Project, Restricted Project
ecatmur added reviewers for D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347: Restricted Project, rsmith.
Fri, May 27, 4:57 PM · Restricted Project, Restricted Project
springerm committed rG1534177f8f7e: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions (authored by springerm).
[mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions
Fri, May 27, 4:51 PM · Restricted Project, Restricted Project
springerm closed D126568: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions.
Fri, May 27, 4:51 PM · Restricted Project, Restricted Project
vsapsai added a comment to D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`..

To trigger "function template|different function template" diagnostic we need the entire "case FunctionTemplate" in "switch (FirstDiffType)" not to detect any mismatches. And I don't know any such cases.

Fri, May 27, 4:47 PM · Restricted Project, Restricted Project
springerm updated the diff for D126252: [mlir][bufferization] Decouple buffer-deallocation from One-Shot Bufferize.

update

Fri, May 27, 4:46 PM · Restricted Project, Restricted Project