Page MenuHomePhabricator

Recent Activity

Today

pengfei added inline comments to D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..
Mon, Apr 12, 11:58 PM · Restricted Project
nicolasvasilache accepted D100364: [mlir][linalg] lower index operations during linalg to loop lowering..

Nice, thanks!

Mon, Apr 12, 11:57 PM · Restricted Project
hanchung abandoned D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mon, Apr 12, 11:53 PM · Restricted Project
gysit added reviewers for D100364: [mlir][linalg] lower index operations during linalg to loop lowering.: pifon2a, ftynse.

The new test cases in loops.mlir duplicate the existing tests for the indexed_generic operation (below). The code after lowering is the same the only difference is the input code (linalg.generic + linalg.index instead of linalg.indexed_generic).

Mon, Apr 12, 11:48 PM · Restricted Project
xiangzhangllvm added inline comments to D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..
Mon, Apr 12, 11:48 PM · Restricted Project
craig.topper committed rG7c9bbbf7358c: [RISCV] Rename RISCVISD::SHFLI to RISCVISD::SHFL and don't require the second… (authored by craig.topper).
[RISCV] Rename RISCVISD::SHFLI to RISCVISD::SHFL and don't require the second…
Mon, Apr 12, 11:47 PM
LuoYuanke updated the diff for D100032: [X86][AMX] Add description of x86_amx to LangRef..

Address Florian and Pengfei's comments.

Mon, Apr 12, 11:46 PM · Restricted Project
gysit requested review of D100364: [mlir][linalg] lower index operations during linalg to loop lowering..
Mon, Apr 12, 11:46 PM · Restricted Project
labath accepted D100195: [lldb] Require x86 for unwind no-return test.

(apologies for the review spam, you're the author of the test in this case)

np

Mon, Apr 12, 11:45 PM · Restricted Project
LuoYuanke added inline comments to D100032: [X86][AMX] Add description of x86_amx to LangRef..
Mon, Apr 12, 11:44 PM · Restricted Project
labath accepted D100140: [lldb] [gdb-remote server] Refactor handling qSupported.

cool

Mon, Apr 12, 11:36 PM
nicolasvasilache requested review of D100363: [mlir][Python][Linalg] Add support for captures in body builder..
Mon, Apr 12, 11:35 PM · Restricted Project
FreddyYe committed rGb28ec3fd18ae: [compiler-rt][X86] fix build fail after "[X86] Support -march=rocketlake" (authored by FreddyYe).
[compiler-rt][X86] fix build fail after "[X86] Support -march=rocketlake"
Mon, Apr 12, 11:34 PM
labath added a comment to D100146: [lldb] [gdb-remote client] Refactor handling qSupported.

looks great, just fix the build errors :)

Mon, Apr 12, 11:27 PM · Restricted Project
mkazantsev accepted D100264: [SCEV] Don't walk uses of phis without SCEV expression when forgetting.

Ok, looks good!

Mon, Apr 12, 11:26 PM · Restricted Project
kuter added a comment to D100339: [Attributor] Run lightweight version of the Attributor by default..

Interesting. Do we have near term plans for adding the Attributor to the default pass pipeline ?

Mon, Apr 12, 11:25 PM · Restricted Project
gribozavr2 accepted D100347: Fix the const overload of IgnoreExprNodes.

Thanks for the fix! Do you have commit access?

Mon, Apr 12, 11:19 PM · Restricted Project
skatkov retitled D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through from [WIP] Teach Greedy RA to recognize special case live-through to [Live Intervals] Teach Greedy RA to recognize special case live-through.
Mon, Apr 12, 11:08 PM · Restricted Project
skatkov added a comment to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.

Is this better?

Mon, Apr 12, 11:05 PM · Restricted Project
skatkov updated the diff for D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Mon, Apr 12, 11:05 PM · Restricted Project
xiangzhangllvm updated the summary of D100026: [X86] Support AMX fast register allocation.
Mon, Apr 12, 11:05 PM · Restricted Project
miscco accepted D100275: [libcxx] adds `forward_iterator` and `forward_range`.
Mon, Apr 12, 11:00 PM · Restricted Project
yonghong-song requested review of D100362: BPF: generate proper BTF for globals with WeakODRLinkage.
Mon, Apr 12, 10:59 PM · Restricted Project
aqjune added a comment to D97924: [LangRef] clarify the semantics of nocapture.

I updated this patch to address comments & added a few examples that I concern.
I hope this helps check whether my understanding about pointer capture is correct.

Mon, Apr 12, 10:57 PM · Restricted Project
myhsu accepted D98537: [M68k] Implement AsmParser.

@myhsu when you get a moment, can you check that this is all OK now? :)

Mon, Apr 12, 10:57 PM · Restricted Project
miscco accepted D100271: [libcxx] adds `input_iterator` and `input_range`.
Mon, Apr 12, 10:56 PM · Restricted Project
miscco added a comment to D100271: [libcxx] adds `input_iterator` and `input_range`.

I like the test coverage but I believe that we should get @CaseyCarter on board to port the ranges test machinery over. It is quite extensive and rebuilding it for the fun of it seems a waste of time

Mon, Apr 12, 10:56 PM · Restricted Project
aeubanks added a comment to rGf2e4f3eff3c9: Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs….

Ah sorry I came up with a repro but didn't find this phab review earlier. https://crbug.com/1198356#c1

Mon, Apr 12, 10:54 PM
miscco added inline comments to D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.
Mon, Apr 12, 10:52 PM · Restricted Project
aqjune updated the diff for D97924: [LangRef] clarify the semantics of nocapture.

Address comments, add a few examples

Mon, Apr 12, 10:52 PM · Restricted Project
jasonmolenda updated subscribers of D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Trying to reword my thinking a little more clearly.

Mon, Apr 12, 10:50 PM · Restricted Project
pengfei added inline comments to D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..
Mon, Apr 12, 10:45 PM · Restricted Project
mstorsjo added a comment to D100359: [COFF] Force Symbols containing '.' to be quoted.

Can you add a testcase?

Mon, Apr 12, 10:42 PM · Restricted Project
aartbik accepted D99818: [mlir] X86Vector: Add AVX Rsqrt.
Mon, Apr 12, 10:39 PM · Restricted Project
ArturGainullin requested review of D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive.
Mon, Apr 12, 10:28 PM · Restricted Project
cjdb committed rG0fcea41920ce: [libcxx][NFC] tweaks `incrementable_traits` per review (authored by cjdb).
[libcxx][NFC] tweaks `incrementable_traits` per review
Mon, Apr 12, 10:22 PM
LuoYuanke accepted D99708: [X86] Enable compilation of user interrupt handlers..

LGTM. But wait one or two days to see if there is more comments from Craig and HJ.

Mon, Apr 12, 10:17 PM · Restricted Project, Restricted Project
cjdb added inline comments to D90999: [libc++] Implements ranges::enable_borrowed_range.
Mon, Apr 12, 10:08 PM · Restricted Project
cjdb committed rGfe31f11cc821: [libcxx] adds `std::incrementable_traits` to <iterator> (authored by cjdb).
[libcxx] adds `std::incrementable_traits` to <iterator>
Mon, Apr 12, 10:03 PM
cjdb closed D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Mon, Apr 12, 10:02 PM · Restricted Project