Page MenuHomePhabricator

Today

samparker added a comment to D72916: [IPO] Don't run jump threading at Oz.

Thanks, you both are indeed right that it can reduce code size... I've now tried reducing BBDuplicateThreshold and it looks like halving this to 3 is the best option (for aarch64 at least). There's a couple of outliers, but most changes are -0.1%:
test-suite...otout/Shootout-nestedloop.test 484 468 -3.3%
test-suite...+/Shootout-C++-nestedloop.test 532 516 -3.0%
test-suite...Olden/perimeter/perimeter.test 2108 2148 1.9%
test-suite...urce/Applications/aha/aha.test 2964 2932 -1.1%
test-suite...ce/Benchmarks/PAQ8p/paq8p.test 53748 53964 0.4%
test-suite...ch/g721/g721encode/encode.test 5468 5452 -0.3%
test-suite...marks/Ptrdist/yacr2/yacr2.test 15204 15236 0.2%
test-suite...ications/JM/ldecod/ldecod.test 161116 160788 -0.2%
test-suite...marks/7zip/7zip-benchmark.test 469784 470728 0.2%
test-suite...chmarks/MallocBench/gs/gs.test 104228 104428 0.2%
test-suite...oxyApps-C/miniAMR/miniAMR.test 34260 34196 -0.2%
test-suite...ications/JM/lencod/lencod.test 380324 380996 0.2%
test-suite...plications/d/make_dparser.test 62816 62912 0.2%
test-suite...s-C/Pathfinder/PathFinder.test 15996 15972 -0.2%
test-suite...ks/Prolangs-C++/city/city.test 5428 5436 0.1%
test-suite.../Benchmarks/Ptrdist/bc/bc.test 27300 27260 -0.1%
test-suite...pplications/oggenc/oggenc.test 105776 105632 -0.1%
test-suite...-typeset/consumer-typeset.test 327944 327520 -0.1%
test-suite...lications/sqlite3/sqlite3.test 244704 244400 -0.1%
test-suite...tions/lambda-0.1.3/lambda.test 20092 20068 -0.1%
test-suite.../Prolangs-C/bison/mybison.test 35828 35788 -0.1%
test-suite...peg2/mpeg2dec/mpeg2decode.test 29916 29884 -0.1%
test-suite.../Applications/SPASS/SPASS.test 287832 288136 0.1%
test-suite...arching-flt/Searching-flt.test 8292 8284 -0.1%
test-suite...arching-dbl/Searching-dbl.test 8500 8492 -0.1%
test-suite...C/Packing-flt/Packing-flt.test 8548 8540 -0.1%
test-suite...ences-flt/Recurrences-flt.test 8644 8636 -0.1%
test-suite...t/StatementReordering-flt.test 8660 8652 -0.1%
test-suite...encode/alacconvert-encode.test 26044 26020 -0.1%
test-suite...decode/alacconvert-decode.test 26044 26020 -0.1%
test-suite...C/Packing-dbl/Packing-dbl.test 8756 8748 -0.1%
test-suite...lications/SIBsim4/SIBsim4.test 26476 26500 0.1%
test-suite...ences-dbl/Recurrences-dbl.test 8852 8844 -0.1%
test-suite...l/StatementReordering-dbl.test 8868 8860 -0.1%
test-suite...ing-flt/LoopRerolling-flt.test 9116 9108 -0.1%
test-suite...ing-flt/Equivalencing-flt.test 9268 9260 -0.1%
test-suite...ing-flt/NodeSplitting-flt.test 9276 9268 -0.1%
test-suite...ing-dbl/LoopRerolling-dbl.test 9340 9332 -0.1%
test-suite...mbolics-flt/Symbolics-flt.test 9364 9356 -0.1%
test-suite...ing-dbl/Equivalencing-dbl.test 9420 9412 -0.1%
test-suite...ing-dbl/NodeSplitting-dbl.test 9476 9468 -0.1%
test-suite...mbolics-dbl/Symbolics-dbl.test 9588 9580 -0.1%
test-suite...lt/IndirectAddressing-flt.test 9708 9700 -0.1%
test-suite...bl/IndirectAddressing-dbl.test 9924 9916 -0.1%
test-suite...lt/CrossingThresholds-flt.test 9940 9932 -0.1%
test-suite...cations/hexxagon/hexxagon.test 10124 10132 0.1%
test-suite...bl/CrossingThresholds-dbl.test 10148 10140 -0.1%
test-suite...flt/InductionVariable-flt.test 10204 10196 -0.1%
test-suite...flt/LoopRestructuring-flt.test 10436 10428 -0.1%
test-suite...ow-flt/GlobalDataFlow-flt.test 10452 10444 -0.1%
test-suite...dbl/InductionVariable-dbl.test 10468 10460 -0.1%
test-suite...oops-flt/ControlLoops-flt.test 10588 10580 -0.1%
test-suite...dbl/LoopRestructuring-dbl.test 10644 10636 -0.1%
test-suite...ow-dbl/GlobalDataFlow-dbl.test 10660 10652 -0.1%
test-suite...oops-dbl/ControlLoops-dbl.test 10780 10772 -0.1%
test-suite...pansion-flt/Expansion-flt.test 10996 10988 -0.1%
test-suite...-flt/LinearDependence-flt.test 11148 11140 -0.1%
test-suite...pansion-dbl/Expansion-dbl.test 11196 11188 -0.1%
test-suite...ctions-flt/Reductions-flt.test 11316 11308 -0.1%
test-suite...-dbl/LinearDependence-dbl.test 11364 11356 -0.1%
test-suite...ctions-dbl/Reductions-dbl.test 11524 11516 -0.1%
test-suite...sc-C++/stepanov_container.test 13132 13140 0.1%
test-suite...lFlow-flt/ControlFlow-flt.test 13764 13756 -0.1%
test-suite...lFlow-dbl/ControlFlow-dbl.test 13972 13964 -0.1%
Geomean difference -0.0%

default-results    threshold-3        diff

count 310.000000 310.000000 310.000000
mean 26375.587097 26377.445161 -0.000273
std 65478.305060 65501.068235 0.002870
min 460.000000 460.000000 -0.033058
25% 1286.000000 1286.000000 0.000000
50% 3128.000000 3128.000000 0.000000
75% 11262.000000 11260.000000 0.000000
max 469784.000000 470728.000000 0.018975

Sat, Jan 18, 2:46 AM · Restricted Project
dmgreen added inline comments to D72919: [AArch64] Add custom store lowering for 256 bit non-temporal stores..
Sat, Jan 18, 2:31 AM · Restricted Project
craig.topper added inline comments to D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together..
Sat, Jan 18, 1:02 AM · Restricted Project
craig.topper updated the diff for D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together..

Rebase. Regenerate with a hacked script to show the real stack offsets for reviewing. I'll regenerate before commiting so the next person who runs the script won't get a surprise.

Sat, Jan 18, 12:54 AM · Restricted Project

Yesterday

saar.raz committed rG027931899763: [Concepts] Requires Expressions (authored by saar.raz).
[Concepts] Requires Expressions
Fri, Jan 17, 11:21 PM
saar.raz closed D50360: [Concepts] Requires Expressions.
Fri, Jan 17, 11:21 PM · Restricted Project
hliao added a comment to D72709: [codegen,amdgpu] Enhance MIR DIE and re-arrange it for AMDGPU..

yeah, here one example

Fri, Jan 17, 11:02 PM · Restricted Project
hliao added a comment to D72941: Handle ptrtoint in InferAddressSpace.

inttoptr and ptrtoint should be treated as opaque ones. If needed, they should be handled with target-specific. This pass is definitely not the place to handle them.

Fri, Jan 17, 10:53 PM · Restricted Project
hliao committed rG6d0d86a64d30: [DAG] Add helper for creating constant vector index with correct type. NFC. (authored by hliao).
[DAG] Add helper for creating constant vector index with correct type. NFC.
Fri, Jan 17, 10:24 PM
mehdi_amini retitled D72933: Adds CastSliceOp to the vector ops dialect. from BEGIN_PUBLIC Adds CastSliceOp to the vector ops dialect. to Adds CastSliceOp to the vector ops dialect..
Fri, Jan 17, 10:15 PM · Restricted Project
annita.zhang added a comment to D72463: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries.

@MaskRay Did you merge it to LLVM 10 branch?

It is included in the release branch.

git branch origin/release/10.x --contains 5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a # suceeded

Fri, Jan 17, 9:34 PM · Restricted Project
friss committed rG546f8f426463: [lldb/testsuite] Modernize 2 test Makefiles (authored by friss).
[lldb/testsuite] Modernize 2 test Makefiles
Fri, Jan 17, 9:07 PM
friss committed rG509b78883d4f: [lldb/Makefile.rules] Force the default target to be 'all' (authored by friss).
[lldb/Makefile.rules] Force the default target to be 'all'
Fri, Jan 17, 9:07 PM
yonghong-song added a comment to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.

@tstellar Thanks for your comments. The MachineInstr SSA based optimization is really a ugly hack. Currently verifier is not able to verify the program correctly, i.e., rejects the program for certain patterns related subregister uses. The commit message provides more information. @ast suggested to look at whether we can improve kernel verifier and I will take a look there. If kernel can be enhanced, I will drop the second MachineInstr SSA pass.

Fri, Jan 17, 8:39 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:30 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:21 PM · Restricted Project
tstellar added a comment to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.

I may not quite understand what the verifier is looking for here, but rather than trying to undo the optimization in 2 different places, would it be possible to implement this by having the InstructionSelector emit some kind of Pseudo Instruction for inputs to the comparison? For example, what would normally be selected to:

Fri, Jan 17, 8:21 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:21 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Removing space

Fri, Jan 17, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Thanks River for the review. Addressed your comments.

Fri, Jan 17, 8:12 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:02 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Testing the change by adapting existing test

Fri, Jan 17, 7:46 PM · Restricted Project
rriddle requested changes to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:44 PM · Restricted Project
rriddle added inline comments to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:44 PM · Restricted Project
aemerson added a comment to D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..

My initial reaction was that the PHI was invalid, but according to @qcolombet it's ok to have different register banks on the operands

Okay... but the operand register class can't actually be *anything*, can it? We have restrictions on COPY instructions.

Those restrictions are target specific though aren’t they? I think it’s the responsibility of ISel to generate valid copies and similar should apply to PHIs.

Fri, Jan 17, 7:36 PM · Restricted Project
kariddi created D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:35 PM · Restricted Project
yonghong-song added inline comments to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.
Fri, Jan 17, 7:35 PM · Restricted Project
ast added inline comments to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.
Fri, Jan 17, 7:25 PM · Restricted Project
DiggerLin created D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D.
Fri, Jan 17, 7:16 PM · Restricted Project
stella.stamenova added a comment to D72957: [mlir] Unbreak MSVC build with implicit constructor.

With the latest VS 2019, the error is still the same (MSVC 19.24).

Fri, Jan 17, 7:16 PM · Restricted Project
MaskRay committed rG9aacec8331d9: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol (authored by MaskRay).
[ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol
Fri, Jan 17, 6:58 PM
MaskRay added a reverting change for rGb841e119d77e: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC: rG9aacec8331d9: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol.
Fri, Jan 17, 6:58 PM
jasonmolenda accepted D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC).

Yep, looks good.

Fri, Jan 17, 6:58 PM · Restricted Project
Harbormaster failed remote builds in B44333: Diff 238937 for D72972: [WebAssembly] Add experimental multivalue calling ABI!
Fri, Jan 17, 6:50 PM · Restricted Project
merge_guards_bot added a comment to D72972: [WebAssembly] Add experimental multivalue calling ABI.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 6:49 PM · Restricted Project
tlively created D72972: [WebAssembly] Add experimental multivalue calling ABI.
Fri, Jan 17, 6:39 PM · Restricted Project
JDevlieghere added a comment to D72940: Add a support for clang tidy to import another configurations files from .clang-tidy.

Please upload the diff with full context. This would also need a test.

Fri, Jan 17, 6:21 PM · Restricted Project, Restricted Project
dblaikie committed rG58b10df54ffd: DebugInfo: Move SectionLabel tracking into CU's addRange (authored by dblaikie).
DebugInfo: Move SectionLabel tracking into CU's addRange
Fri, Jan 17, 6:20 PM
JDevlieghere created D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC).
Fri, Jan 17, 6:11 PM · Restricted Project
arsenm updated the diff for D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass.

Formatting

Fri, Jan 17, 6:01 PM · Restricted Project