HomePhabricator

add a dependency on terminfo library if llvm uses it

Description

add a dependency on terminfo library if llvm uses it

Ncurses related symbols can either all be found in libnurses or split
between libncurses and libtinfo. The main LLVM cmake scripts look for the
setupterm symbol and stores the library that has it in TERMINFO_LIBS. This
covers the split and unified ncurses case. LLDB uses symbols that can end
up in libtinfo so this library should be pulled in if it is found.

There is still an exotic case left where LLDB is configured with
-DLLDB_DISABLE_CURSES=NO and LLVM with -DLLVM_ENABLE_TERMINFO=NO but
misconfigurations will always be possible. Possibly a diagnostic could be
added for that.

This fixes bug 24693.

Differential Revision: http://reviews.llvm.org/D12672
Patch by Jeremi Piotrowski

Details

Committed
zturnerSep 16 2015, 1:14 PM
Differential Revision
D12672: add a dependency on terminfo library if llvm uses it
Parents
rLLDB247841: Fix log disable command in ProcessWindowsLog.
Branches
Unknown
Tags
Unknown