HomePhabricator

StackProtector: Use PointerMayBeCaptured

Description

StackProtector: Use PointerMayBeCaptured

This was using its own, outdated list of possible captures. This was
at minimum not catching cmpxchg and addrspacecast captures.

One change is now any volatile access is treated as capturing. The
test coverage for this pass is quite inadequate, but this required
removing volatile in the lifetime capture test.

Also fixes some infrastructure issues to allow running just the IR
pass.

Fixes bug 42238.

Details

Committed
arsenmJun 12 2019, 7:23 AM
Parents
rL363168: AMDGPU/GlobalISel: Fix using illegal situations in tests
Branches
Unknown
Tags
Unknown

Event Timeline

ychen added a subscriber: ychen.Sep 10 2019, 3:53 PM

Unfortunately this commit causes a serious regression in SSP. I have raised bug 43308:

https://bugs.llvm.org/show_bug.cgi?id=43308