HomePhabricator

[opaque pointer types] Add a FunctionCallee wrapper type, and use it.

Description

[opaque pointer types] Add a FunctionCallee wrapper type, and use it.

The FunctionCallee type is effectively a {FunctionType*,Value*} pair,
and is a useful convenience to enable code to continue passing the
result of getOrInsertFunction() through to EmitCall, even once pointer
types lose their pointee-type.

Then:

  • update the CallInst/InvokeInst instruction creation functions to take a Callee,
  • modify getOrInsertFunction to return FunctionCallee, and
  • update all callers appropriately.

One area of particular note is the change to the sanitizer
code. Previously, they had been casting the result of
getOrInsertFunction to a Function* via
checkSanitizerInterfaceFunction, and storing that. That would report
an error if someone had already inserted a function declaraction with
a mismatching signature.

However, in general, LLVM allows for such mismatches, as
getOrInsertFunction will automatically insert a bitcast if
needed. As part of this cleanup, cause the sanitizer code to do the
same. (It will call its functions using the expected signature,
however they may have been declared.)

Finally, in a small number of locations, callers of
getOrInsertFunction actually were expecting/requiring that a brand
new function was being created. In such cases, I've switched them to
Function::Create instead.

Differential Revision: https://reviews.llvm.org/D57315

Details

Committed
jyknightJan 31 2019, 12:35 PM
Differential Revision
D57315: [opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Parents
rL352790: [cmake] Note future cleanup in comment. NFC
Branches
Unknown
Tags
Unknown