HomePhabricator

Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp…
Concern RaisedrL335206

Description

Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp instructions.

r335150 should resolve the issues with the clang-with-thin-lto-ubuntu
and clang-with-lto-ubuntu builders.

Original message:
This patch updates IPSCCP to use PredicateInfo to propagate
facts to true branches predicated by EQ and to false branches
predicated by NE.

As a follow up, we should be able to extend it to also propagate additional
facts about nonnull.

Reviewers: davide, mssimpso, dberlin, efriedma

Reviewed By: davide, dberlin

Details

Auditors
thegameg
Committed
fhahnJun 21 2018, 12:15 AM
Reviewer
davide
Parents
rL335205: [DebugInfo] Keep DBG_VALUE undef in LiveDebugVariables
Branches
Unknown
Tags
Unknown

Event Timeline

thegameg raised a concern with this commit.Jun 21 2018, 9:01 AM
thegameg added a subscriber: thegameg.

I raised concern on the wrong commit: https://reviews.llvm.org/rL333740. It does reproduce with this commit as well.

This commit now has outstanding concerns.Jun 21 2018, 9:01 AM