HomePhabricator

[StackColoring] Update AliasAnalysis information in stack coloring pass (part 2)

Description

[StackColoring] Update AliasAnalysis information in stack coloring pass (part 2)

This patch is update after the first patch (https://reviews.llvm.org/rL309651) based on the post-commit comments.

Stack coloring pass need to maintain AliasAnalysis information when merging stack slots of different types.
Actually, there is a FIXME comment in StackColoring.cpp

FIXME: In order to enable the use of TBAA when using AA in CodeGen,
we'll also need to update the TBAA nodes in MMOs with values
// derived from the merged allocas.

But, TBAA has been already enabled in CodeGen without fixing this pass.
The incorrect TBAA metadata results in recent failures in bootstrap test on ppc64le (PR33928) by allowing unsafe instruction scheduling.
Although we observed the problem on ppc64le, this is a platform neutral issue.

This patch makes the stack coloring pass maintains AliasAnalysis information when merging multiple stack slots.

This patch fixes PR33928.

Details

Committed
inouehrsAug 2 2017, 11:16 AM
Parents
rL309848: This ppc64 implementation of clear_cache works for both big and little endian.
Branches
Unknown
Tags
Unknown