HomePhabricator

[InstCombine] canonicalize min/max constant to select's false value

Description

[InstCombine] canonicalize min/max constant to select's false value

This is a first step towards canonicalization and improved folding/codegen
for integer min/max as discussed here:
http://lists.llvm.org/pipermail/llvm-dev/2016-November/106868.html

Here, we're just matching the simplest min/max patterns and adjusting the
icmp predicate while swapping the select operands.

I've included FIXME tests in test/Transforms/InstCombine/select_meta.ll
so it's easier to see how this might be extended (corresponds to the TODO
comment in the code). That's also why I'm using matchSelectPattern()
rather than a simpler check; once the backend is patched, we can just
remove some of the restrictions to allow the obfuscated min/max patterns
in the FIXME tests to be matched.

Differential Revision: https://reviews.llvm.org/D26525

Details

Committed
spatelNov 21 2016, 2:04 PM
Differential Revision
D26525: [InstCombine] canonicalize min/max constant to select's false value
Parents
rL287584: LSR debug fix.
Branches
Unknown
Tags
Unknown