HomePhabricator

Fixed being able to set breakpoints on destructors when we don't fully…

Description

Fixed being able to set breakpoints on destructors when we don't fully specify the demangled name. So all of the following now work:

(lldb) b ~Foo
(lldb) b Foo::~Foo
(lldb) b Bar::Foo::~Foo

Improved out C++ breakpoint locations tests as well to cover this issue.

rdar://problem/25577252

Details

Committed
gclaytonApr 12 2016, 3:02 PM
Parents
rL266138: Use the FormatEntity work for great good - parse summary strings before…
Branches
Unknown
Tags
Unknown

Event Timeline

Hi Greg,

looks like this CL is causing TestCPPBreakpointLocations to fail on CMake build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13329

tberghammer added inline comments.
/lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
333

I think we don't need the second '~' as now you are accepting things like

~~Foo, ~, ~~

what shouldn't been accepted. I am happy to make the CL for removing it, but wanted to make sure I am not missing something.