HomePhabricator

[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo
AuditedrL247968

Description

[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

SUMMARY:
Using response.IsUnsupportedResponse instead of !response.IsNormalResponse().

Reviewers: clayborg, labath
Subscribers: nitesh.jain, mohit.bhakkad, sagar, bhushan and lldb-commits
Differential Revision: http://reviews.llvm.org/D12876

Details

Auditors
dawn
Committed
jaydeepSep 17 2015, 10:32 PM
Parents
rL247967: Driver: avoid unnecessary string based operations
Branches
Unknown
Tags
Unknown

Event Timeline

dawn raised a concern with this commit.Sep 23 2015, 3:15 PM
dawn added a subscriber: lldb-commits.
dawn added a subscriber: dawn.

Hi Jay,

This test has been failing on OSX ever since this commit:

./dotest.py -f ConnectRemoteTestCase.test_connect_remote
Failure-TestConnectRemote.ConnectRemoteTestCase.test_connect_remote-x86_64-clang.log

lldb is built with cmake/ninja, and tests are run in the test dir as follows:

cd ~/llvm
mkdir -p build_ninja && cd build_ninja
cmake -G Ninja .. "-DLLVM_TARGETS_TO_BUILD=ARM;X86;AArch64" -DCMAKE_CXX_FLAGS="-std=c++11 -stdlib=libc++" -DCMAKE_BUILD_TYPE=Release
security unlock-keychain -p <psw>  /Users/testuser/Library/Keychains/login.keychain
ninja
cd ../tools/lldb/test
./dotest.py --output-on-success -v

Can you have a look please?

Thanks in advance,
-Dawn

Hi Dawn,

Let me check and get back to you.

Regards,
Jaydeep

dawn added a comment.Oct 6 2015, 5:34 PM

This test is still failing. Can you please have a look? Thanks.

Hi Dawn,

Could you please provide more details on this?

Thanks,
Jaydeep

dawn accepted this commit.Oct 8 2015, 7:09 PM

The filing test was removed by Greg in r249613.