HomePhabricator
Diffusion LLVM rL247773

[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo
AuditedrL247773
Actions

Description

[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

SUMMARY:
Refer to http://lists.llvm.org/pipermail/lldb-dev/2015-August/008024.html for discussion
on this topic. Bare-iron target like YAMON gdb-stub does not support qProcessInfo, qC,
qfThreadInfo, Hg and Hc packets. Reply from ? packet is as simple as S05. There is no 
packet which gives us process or threads information. In such cases, assume pid=tid=1.

Reviewers: clayborg
Subscribers: nitesh.jain, mohit.bhakkad, sagar, bhushan and lldb-commits
Differential Revision: http://reviews.llvm.org/D12876

Details

Auditors
dawn
Committed
jaydeepSep 15 2015, 9:04 PM
Parents
rL247772: Use range-based for loops. NFC
Branches
Unknown
Tags
Unknown

Event Timeline

jaydeep committed rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo.Sep 15 2015, 9:04 PM
dawn added a subscriber: lldb-commits.Sep 23 2015, 12:28 PM
dawn raised a concern with this commit.Sep 23 2015, 2:34 PM
dawn added a subscriber: dawn.

Hi Jay,

This test has been failing on OSX ever since this commit:

./dotest.py -f TestCppNsImport.test_with_dwarf_and_run_command
Failure-TestCppNsImport.TestCppNsImport.test_with_dwarf_and_run_command-x86_64-clang.log

lldb is built with cmake/ninja, and tests are run in the test dir as follows:

cd ~/llvm
mkdir -p build_ninja && cd build_ninja
cmake -G Ninja .. "-DLLVM_TARGETS_TO_BUILD=ARM;X86;AArch64" -DCMAKE_CXX_FLAGS="-std=c++11 -stdlib=libc++" -DCMAKE_BUILD_TYPE=Release
security unlock-keychain -p <psw>  /Users/testuser/Library/Keychains/login.keychain
ninja
cd ../tools/lldb/test
./dotest.py --output-on-success -v

Can you have a look please?

Thanks in advance,
-Dawn

dawn added a comment.Oct 6 2015, 5:34 PM

This test is still failing. Can you please have a look? Thanks.

jaydeep added a comment.Oct 7 2015, 3:57 AM

Hi Dawn,

Could you please provide more details on this?

Thanks,
Jaydeep

dawn added a comment.Oct 7 2015, 8:29 PM

What other details are you looking for?

jaydeep added a comment.Oct 7 2015, 10:35 PM

Hi Dwan,

Could you please try http://reviews.llvm.org/rL247968 and let me know if the issue persist?

Thanks,
Jaydeep

dawn accepted this commit.Oct 8 2015, 7:12 PM

This test is no longer failing.

Changes (1)

PathSize
lldb/
trunk/
source/
Plugins/
Process/
gdb-remote/

rL247773

View Options

lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Loading...