HomePhabricator

[lldb-mi] Clean up CMICmdArgSet usage.

Description

[lldb-mi] Clean up CMICmdArgSet usage.

Summary:
CMICmdArgSet stores a vector of non-const pointers to the arguments
that it is validating. It owns them and is responsible for deleting
them.

We don't need to pass a const reference to the argument to
CMICmdArgSet::Add and then take the address and const_cast it
when we can just pass the argument pointer in directly.

This lets us remove some noise at every call site for CMICmdArgSet::Add
and then clean up a couple of bits inside CMICmdArgSet to remove
const_casts.

Reviewers: abidh, ki.stfu, domipheus

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D12878

Details

Committed
brucemSep 15 2015, 5:00 AM
Differential Revision
D12878: [lldb-mi] Clean up CMICmdArgSet usage.
Parents
rL247676: [OpenCL] Add new types for OpenCL 2.0.
Branches
Unknown
Tags
Unknown