Default to linking lldb-server statically for Android.
Reviewers: vharron, tberghammer
Subscribers: chaoren, labath, tberghammer, lldb-commits
Differential Revision: http://reviews.llvm.org/D10858
I reverted this CL because it causes lldb-server crash on the android builder at startup (resulting in 100% test failure).
The issue happens when you run lldb-platform with "--listen localhost:5432". If you run it with "--listen *:5432" or with "--listen 127.0.0.1:5432" then everything works fine.
Backtrace of the crash:
* thread #1: tid = 24092, 0x01081518 lldb-server`freeaddrinfo(ai=0x00000000) + 4 at getaddrinfo.c:331, name = 'lldb-server', stop reason = signal SIGSEGV: invalid address (fault address: 0x14) * frame #0: 0x01081518 lldb-server`freeaddrinfo(ai=0x00000000) + 4 at getaddrinfo.c:331 frame #1: 0x000a4c80 lldb-server`lldb_private::SocketAddress::getaddrinfo(char const*, char const*, int, int, int, int) + 156 frame #2: 0x000a4570 lldb-server`lldb_private::Socket::BlockingAccept(llvm::StringRef, bool, lldb_private::Socket*&) + 768 frame #3: 0x0007f970 lldb-server`main_platform(int, char**) + 1812 frame #4: 0x000791dc lldb-server`main + 68 frame #5: 0x01091f0e lldb-server`::__libc_init(raw_args=<unavailable>, onexit=<unavailable>, slingshot=0x00079198, structors=0x00000000)(), int (*)(int, char **, char **), const structors_array_t *const) + 166 at libc_init_static.cpp:111 frame #6: 0x0007cb98 lldb-server`_start + 92
Logs from logcat:
I'm wondering if we really need to support localhost (or any other
The buildbot still failing because of this change but I hope it will be fixed when the master is restarted.
Generally I have 2 concern with this change even if the buildbot is modified:
be displayed instead of a segfault.
Yes, the segfault is caused by freeing a null addrinfo*. After I land
to be confident with the stability of lldb-server we have to test it with
There is going to be this risk no matter what we went with (dynamic linking
The buildbot still failing because of this change but I hope it will be
Generally I have 2 concern with this change even if the buildbot is
localhost:5432" and expect it to work. We can say we don't accept it, but
incompatible version of API level. The current issue can be worked around
chaoren (Author, Auditor) tberghammer (Auditor)
Also, yes the build bot will be failing until the master restarts and we'll