HomePhabricator

Reapply r235977 "[DebugInfo] Add debug locations to constant SD nodes"
Audit RequiredrL235989

Description

Reapply r235977 "[DebugInfo] Add debug locations to constant SD nodes"

[DebugInfo] Add debug locations to constant SD nodes

This adds debug location to constant nodes of Selection DAG and updates
all places that create constants to pass debug locations
(see PR13269).

Can't guarantee that all locations are correct, but in a lot of cases choice
is obvious, so most of them should be. At least all tests pass.

Tests for these changes do not cover everything, instead just check it for
SDNodes, ARM and AArch64 where it's easy to get incorrect locations on
constants.

This is not complete fix as FastISel contains workaround for wrong debug
locations, which drops locations from instructions on processing constants,
but there isn't currently a way to use debug locations from constants there
as llvm::Constant doesn't cache it (yet). Although this is a bit different
issue, not directly related to these changes.

Differential Revision: http://reviews.llvm.org/D9084

Details

Auditors
dsanders
Committed
sdmitroukApr 28 2015, 7:05 AM
Differential Revision
D9084: [DebugInfo] Add debug locations to constant SD nodes
Parents
rL235988: Use CIE version 4 for dwarf4.
Branches
Unknown
Tags
Unknown