HomePhabricator

[ASan] Use metadata to pass source-level information from Clang to ASan.

Description

[ASan] Use metadata to pass source-level information from Clang to ASan.

Instead of creating global variables for source locations and global names,
just create metadata nodes and strings. They will be transformed into actual
globals in the instrumentation pass (if necessary). This approach is more
flexible:

  1. we don't have to ensure that our custom globals survive all the optimizations
  2. if globals are discarded for some reason, we will simply ignore metadata for them and won't have to erase corresponding globals
  3. metadata for source locations can be reused for other purposes: e.g. we may attach source location metadata to alloca instructions and provide better descriptions for stack variables in ASan error reports.

No functionality change.

Details

Committed
samsonovAug 1 2014, 5:35 PM
Parents
rL214603: After you attach, give the process plugin a chance to report back (through
Branches
Unknown
Tags
Unknown

Event Timeline