HomePhabricator

[PowerPC] ELFv2 function call changes

Description

[PowerPC] ELFv2 function call changes

This patch builds upon the two preceding MC changes to implement the
basic ELFv2 function call convention. In the ELFv1 ABI, a "function
descriptor" was associated with every function, pointing to both the
entry address and the related TOC base (and a static chain pointer
for nested functions). Function pointers would actually refer to that
descriptor, and the indirect call sequence needed to load up both entry
address and TOC base.

In the ELFv2 ABI, there are no more function descriptors, and function
pointers simply refer to the (global) entry point of the function code.
Indirect function calls simply branch to that address, after loading it
up into r12 (as required by the ABI rules for a global entry point).
Direct function calls continue to just do a "bl" to the target symbol;
this will be resolved by the linker to the local entry point of the
target function if it is local, and to a PLT stub if it is global.
That PLT stub would then load the (global) entry point address of the
final target into r12 and branch to it. Note that when performing a
local function call, r2 must be set up to point to the current TOC
base: if the target ends up local, the ABI requires that its local
entry point is called with r2 set up; if the target ends up global,
the PLT stub requires that r2 is set up.

This patch implements all LLVM changes to implement that scheme:

  • No longer create a function descriptor when emitting a function definition (in EmitFunctionEntryLabel)
  • Emit two entry points *if* the function needs the TOC base (r2) anywhere (this is done EmitFunctionBodyStart; note that this cannot be done in EmitFunctionBodyStart because the global entry point prologue code must be *part* of the function as covered by debug info).
  • In order to make use tracking of r2 (as needed above) work correctly, mark direct function calls as implicitly using r2.
  • Implement the ELFv2 indirect function call sequence (no function descriptors; load target address into r12).
  • When creating an ELFv2 object file, emit the .abiversion 2 directive to tell the linker to create the appropriate version of PLT stubs.

Reviewed by Hal Finkel.

Details

Committed
uweigandJul 20 2014, 4:31 PM
Parents
rL213488: [LoopVectorize] Remove an unused private AA pointer
Branches
Unknown
Tags
Unknown

Event Timeline