Home

ARM: expand atomic ldrex/strex loops in IR

Press ? to show keyboard shortcuts.
Committed
tnorthoverApr 3 2014, 4:44 AM
Parents
rL205524: PR19320:
Branches
Unknown
Tags
Unknown
Subscribers
None
Projects
None
Description

ARM: expand atomic ldrex/strex loops in IR

The previous situation where ATOMIC_LOAD_WHATEVER nodes were expanded
at MachineInstr emission time had grown to be extremely large and
involved, to account for the subtly different code needed for the
various flavours (8/16/32/64 bit, cmpxchg/add/minmax).

Moving this transformation into the IR clears up the code
substantially, and makes future optimisations much easier:

  1. an atomicrmw followed by using the *new* value can be more efficient. As an IR pass, simple CSE could handle this efficiently.
  2. Making use of cmpxchg success/failure orderings only has to be done in one (simpler) place.
  3. The common "cmpxchg; did we store?" idiom can be exposed to optimisation.

I intend to gradually improve this situation within the ARM backend
and make sure there are no hidden issues before moving the code out
into CodeGen to be shared with (at least ARM64/AArch64, though I think
PPC & Mips could benefit too).

rL205525

llvm/trunk/lib/Target/ARM/ARM.h

Loading...

llvm/trunk/lib/Target/ARM/ARMAtomicExpandPass.cpp

Loading...

llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp

Loading...

llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Loading...

llvm/trunk/lib/Target/ARM/ARMISelLowering.h

Loading...

llvm/trunk/lib/Target/ARM/ARMInstrInfo.td

Loading...

llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp

Loading...

llvm/trunk/lib/Target/ARM/CMakeLists.txt

Loading...

llvm/trunk/test/CodeGen/ARM/atomic-64bit.ll

Loading...

llvm/trunk/test/CodeGen/ARM/atomic-ops-v8.ll

Loading...

llvm/trunk/test/CodeGen/ARM/atomicrmw_minmax.ll

Loading...

Add Comment