HomePhabricator

[DAG] Fix an assertion failure caused by an invalid cast in method…
rL204536Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

[DAG] Fix an assertion failure caused by an invalid cast in method 'BuildVectorSDNode::isConstantSplat'

This patch renames method 'isConstantSplat' as 'getConstantSplatValue'
(mainly for consistency reasons), and rewrites its logic to ensure
that we always perform a legal 'cast<ConstantSDNode>'.

Added test shift-combine-crash.ll to verify that DAGCombiner no longer crashes with an assertion failure in the attempt to simplify a vector shift by a vector of all undef counts.

Details

Committed
adibiagioMar 21 2014, 6:47 PM
Parents
rL204535: Refactor: move loading pending instantiations from chained PCHs to a more…
Branches
Unknown
Tags
Unknown

Event Timeline